From owner-svn-src-all@FreeBSD.ORG Thu Dec 13 07:22:52 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 94A5F9FB; Thu, 13 Dec 2012 07:22:52 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id 621148FC08; Thu, 13 Dec 2012 07:22:51 +0000 (UTC) Received: by mail-vc0-f182.google.com with SMTP id fo14so1855751vcb.13 for ; Wed, 12 Dec 2012 23:22:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; bh=uatyFkQAN5gTwi+upmX3Fk3S7alT6uXgsqsNr8/2VEE=; b=m0JHvp+FVOgkVSoEWbFaZQwr6V/EDuIFWk+XJ/0EVzmgBzGilsziJcFztyn7D5IMKz nDU6PKXjW0QgQZhxoMlJDYyARqRL7Z5x1ewOOZbtx8KtmYKDIu/RVqamhVyyJ9OcyJMV rYcZQcslBw1YIXp5HOm6D1rekTc1hcX6pCaDQ5xbBDd3+S4pm9EaiTx996s2I5K5QoZl rOdSBa8aNZp2vSi1IQ+jseCLu+cIqazeQDnekkgqccAoJb/iYvCe0H8w5vQnjz7XqgPx /IISWkryz/U8zjUlJY9QQhr5BJz6LhowIrBFWJXKO2q6nheWAJdnO2ayukX8Ol7B0hPW FBMw== MIME-Version: 1.0 Received: by 10.52.67.133 with SMTP id n5mr1351397vdt.24.1355383370875; Wed, 12 Dec 2012 23:22:50 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.58.201.202 with HTTP; Wed, 12 Dec 2012 23:22:50 -0800 (PST) In-Reply-To: <20121213071938.GA2074@itx> References: <201212110708.qBB78EWx025288@svn.freebsd.org> <201212121046.43706.jhb@freebsd.org> <201212121658.49048.jhb@freebsd.org> <50C90567.8080406@FreeBSD.org> <50C909BD.9090709@mu.org> <50C97D94.1090603@FreeBSD.org> <20121213071938.GA2074@itx> Date: Wed, 12 Dec 2012 23:22:50 -0800 X-Google-Sender-Auth: v6d_jHq8RFZLF1fkCgG92hS7r4A Message-ID: Subject: Re: svn commit: r244112 - head/sys/kern From: Adrian Chadd To: Adrian Chadd , Andriy Gapon , Alfred Perlstein , John Baldwin , Alfred Perlstein , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Dec 2012 07:22:52 -0000 On 12 December 2012 23:19, Navdeep Parhar wrote: > On Wed, Dec 12, 2012 at 11:07:58PM -0800, Adrian Chadd wrote: >> Andriy, >> >> If you are willing to enable INVARIANTS by default in GENERIC, right >> now, then I think we should remove Alfred's work. > > It's already enabled by default in GENERIC in the development branch > (aka head), which is exactly the right thing to do. Surely, you're not > advocating we enable it by default in any release branch? I'm sure at least one vendor out there would love to ship GENERIC + INVARIANTS minus the panic bit, so they get all of the invariants reporting and checking, but none of the panicing (which wouldn't occur if INVARIANTS wasn't compiled in.) WITNESS is still slow, but after I fixed a rather hilarious strlen() abuse in it, it actually started to be more useful to enable at runtime on my test equipment by default. Before I fixed that strlen() issue, I couldn't get anywhere near line rate ethernet/wifi throughput, so I didn't want to leave it on. Adrian