Date: Thu, 14 May 2015 09:24:25 -0400 (EDT) From: Rick Macklem <rmacklem@uoguelph.ca> To: Edward Tomasz =?utf-8?Q?Napiera=C5=82a?= <trasz@FreeBSD.org> Cc: FreeBSD Filesystems <freebsd-fs@freebsd.org> Subject: Re: RFC: should automounted file systems be exportable? Message-ID: <1693868675.37887047.1431609865698.JavaMail.root@uoguelph.ca> In-Reply-To: <20150512074602.GA93864@brick.home>
next in thread | previous in thread | raw e-mail | index | archive | help
------=_Part_37887045_646449297.1431609865694 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Edward Tomasz Napierala wrote: > On 0511T2217, Rick Macklem wrote: > > A recent bug was reported related to mountd and the > > "automounted" flag. > > > > Loosely related to this is the question... > > Should automounted file systems be exportable? > > > > I haven't tested it, but I suspect that it would be > > broken and the NFS server will reply NFSERR_STALE > > after the file system has been dismounted. > > > > So, should I patch mountd so that it won't export > > automounted file systems? > > Exporting an automounted filesystem doesn't seem to make much sense, > I agree, but I'm not sure if adding code to prevent it is such > a good idea. If the user asks for it, by putting it into exports(5), > it's his fault; the only thing this code could add would be a more > friendly error message. > > So, how about having mountd generate a warning message in syslog(), but allow it to proceed? (Untested patch for this is attached.) rick ps: One other person emailed me suggesting that it should be doable and no one emailed that it should be restricted, so I figure that the "vote" favours a warning. ------=_Part_37887045_646449297.1431609865694 Content-Type: text/x-patch; name=mountd-automount.patch Content-Disposition: attachment; filename=mountd-automount.patch Content-Transfer-Encoding: base64 LS0tIG1vdW50ZC5jLm9yaWcJMjAxNS0wNS0wOSAyMjowNDoxNS4wMDAwMDAwMDAgLTA0MDAKKysr IG1vdW50ZC5jCTIwMTUtMDUtMTQgMDk6MTg6MDEuMDAwMDAwMDAwIC0wNDAwCkBAIC0xNDEwLDYg KzE0MTAsOSBAQCBnZXRfZXhwb3J0bGlzdF9vbmUodm9pZCkKIAkJCSAgICB9CiAJCQkgICAgaWYg KGNoZWNrX2RpcnBhdGgoY3ApICYmCiAJCQkJc3RhdGZzKGNwLCAmZnNiKSA+PSAwKSB7CisJCQkJ aWYgKChmc2IuZl9mbGFncyAmIE1OVF9BVVRPTU9VTlRFRCkgIT0gMCkKKwkJCQkgICAgc3lzbG9n KExPR19FUlIsICJXYXJuaW5nOiBleHBvcnRpbmcgb2YgIgorCQkJCQkiYXV0b21vdW50ZWQgZnMg JXMgbm90IHN1cHBvcnRlZCIsIGNwKTsKIAkJCQlpZiAoZ290X25vbmRpcikgewogCQkJCSAgICBz eXNsb2coTE9HX0VSUiwgImRpcnMgbXVzdCBiZSBmaXJzdCIpOwogCQkJCSAgICBnZXRleHBfZXJy KGVwLCB0Z3JwKTsK ------=_Part_37887045_646449297.1431609865694--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1693868675.37887047.1431609865698.JavaMail.root>