From owner-p4-projects@FreeBSD.ORG Wed Oct 11 22:26:53 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id BD23E16A416; Wed, 11 Oct 2006 22:26:53 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9663F16A40F; Wed, 11 Oct 2006 22:26:53 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe07.swip.net [212.247.154.193]) by mx1.FreeBSD.org (Postfix) with ESMTP id D809043D46; Wed, 11 Oct 2006 22:26:52 +0000 (GMT) (envelope-from hselasky@c2i.net) X-T2-Posting-ID: gvlK0tOCzrqh9CPROFOFPw== X-Cloudmark-Score: 0.000000 [] Received: from [193.216.120.97] (HELO [10.0.0.249]) by mailfe07.swip.net (CommuniGate Pro SMTP 5.0.8) with ESMTP id 299447037; Thu, 12 Oct 2006 00:26:50 +0200 From: Hans Petter Selasky To: Warner Losh Date: Thu, 12 Oct 2006 00:27:09 +0200 User-Agent: KMail/1.7 References: <200610080546.k985k2Eb052621@repoman.freebsd.org> In-Reply-To: <200610080546.k985k2Eb052621@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200610120027.10842.hselasky@c2i.net> Cc: Perforce Change Reviews Subject: Re: PERFORCE change 107486 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Oct 2006 22:26:54 -0000 On Sunday 08 October 2006 07:46, Warner Losh wrote: > http://perforce.freebsd.org/chv.cgi?CH=107486 > > Change 107486 by imp@imp_paco-paco on 2006/10/08 05:45:21 > > compile > > Affected files ... > > .. //depot/projects/usb/src/sys/dev/usb/udbp.h#5 edit > > Differences ... > > ==== //depot/projects/usb/src/sys/dev/usb/udbp.h#5 (text+ko) ==== > > @@ -60,8 +60,8 @@ > > /* This structure is returned by the NGM_UDBP_GET_STATUS command */ > struct ngudbpstat { > - uint packets_in; /* packets in from downstream */ > - uint packets_out; /* packets out towards downstream */ > + int packets_in; /* packets in from downstream */ > + int packets_out; /* packets out towards downstream */ > }; Are you sure that this shouldn't be "uint32_t" ? --HPS