From owner-cvs-all@FreeBSD.ORG Tue May 4 03:15:07 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4708016A4CE; Tue, 4 May 2004 03:15:07 -0700 (PDT) Received: from rwcrmhc13.comcast.net (rwcrmhc13.comcast.net [204.127.198.39]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0013B43D1F; Tue, 4 May 2004 03:15:06 -0700 (PDT) (envelope-from DougB@dougbarton.net) Received: from dougbarton.net (dhcp-8-243.ripemtg.ripe.net[193.0.8.243]) by comcast.net (rwcrmhc13) with ESMTP id <200405041015040150081338e> (Authid: domain_name_tsar); Tue, 4 May 2004 10:15:06 +0000 Message-ID: <40976D24.4060408@DougBarton.net> Date: Tue, 04 May 2004 12:15:00 +0200 From: Doug Barton User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.6) Gecko/20040418 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andre Oppermann References: <200405040239.i442dfL0011742@repoman.freebsd.org> <40970329.3070507@freebsd.org> <40975C30.5D247B83@freebsd.org> In-Reply-To: <40975C30.5D247B83@freebsd.org> X-Enigmail-Version: 0.83.6.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Scott Long cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/net if_vlan.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 May 2004 10:15:07 -0000 Andre Oppermann wrote: > However it worked for me just fine. The reason I just found out is that > I wasn't compiling if_vlan into the kernel but loaded and tested it as > module. Compiling it as module doesn't give any compiler warning and > works w/o a hitch. Dunno why? Testing both should be standard operating procedure before you commit. Of course there _should_ be no difference, but that's why you do testing on stuff like this. Doug -- If you're never wrong, you're not trying hard enough