From owner-svn-ports-all@freebsd.org  Tue Dec 15 06:32:47 2015
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D0A03A43E84;
 Tue, 15 Dec 2015 06:32:47 +0000 (UTC)
 (envelope-from antoine.brodin.freebsd@gmail.com)
Received: from mail-io0-x22b.google.com (mail-io0-x22b.google.com
 [IPv6:2607:f8b0:4001:c06::22b])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id A15791B7D;
 Tue, 15 Dec 2015 06:32:47 +0000 (UTC)
 (envelope-from antoine.brodin.freebsd@gmail.com)
Received: by mail-io0-x22b.google.com with SMTP id 186so9444219iow.0;
 Mon, 14 Dec 2015 22:32:47 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=zUu3XPH6O8genKMJnXmgiUdw/ccKyPRNbMX3ZFZevBI=;
 b=cpKeaAORRv54GScT9KRODVdLhITIOrdMgMHcRyp3Yqx+a/Bk5giFjSfQeHezPO6Y3v
 fKDcc8lceQscmnAuu5wvsoRI3Umxg03tsnpx+ameq5lq2OumN+LTFR3KUk5sr9EVt2bU
 dQj46lPLoK492xV4hg3+M1bYT7wwoGBgRwRzMDwA7S7ox2kIF4vQLDg6tRi83ZT4x0JZ
 mtgHEg0lx5Cg9Vr300Xg1g5fzq/I2S/EaFRL4SKquBL7gXRHwzBGguliqssh8R/0bs+C
 9Wq5WZ0fn0a4csVPhGykou28m1Ch3o0ST1/9efChIBpaIknMqf8Wt+7keffWa2fjAGX7
 M+1A==
MIME-Version: 1.0
X-Received: by 10.107.47.66 with SMTP id j63mr31709596ioo.168.1450161166946;
 Mon, 14 Dec 2015 22:32:46 -0800 (PST)
Sender: antoine.brodin.freebsd@gmail.com
Received: by 10.107.182.67 with HTTP; Mon, 14 Dec 2015 22:32:46 -0800 (PST)
In-Reply-To: <201512142302.tBEN2n9c074595@repo.freebsd.org>
References: <201512142302.tBEN2n9c074595@repo.freebsd.org>
Date: Tue, 15 Dec 2015 07:32:46 +0100
X-Google-Sender-Auth: Z9Xq3a4zvZH4MNuBkx5PdPwzj-4
Message-ID: <CAALwa8mNQHfKaixr2rYtAjzAC-aHQ1Yzfw2ec7e-bfrGjOTw2g@mail.gmail.com>
Subject: Re: svn commit: r403745 - head/java/openjdk8
From: Antoine Brodin <antoine@FreeBSD.org>
To: Jung-uk Kim <jkim@freebsd.org>
Cc: "ports-committers@freebsd.org" <ports-committers@freebsd.org>, 
 "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, 
 "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Dec 2015 06:32:47 -0000

On Tue, Dec 15, 2015 at 12:02 AM, Jung-uk Kim <jkim@freebsd.org> wrote:
> Author: jkim
> Date: Mon Dec 14 23:02:49 2015
> New Revision: 403745
> URL: https://svnweb.freebsd.org/changeset/ports/403745
>
> Log:
>   Respect CC, CPP and CXX with full paths.
>
>   PR:           203747
>
> Modified:
>   head/java/openjdk8/Makefile

This breaks INDEX on FreeBSD 9  (no new packages for FreeBSD 9 users
in the next 2 days)

java/openjdk8 % fmake describe
Unknown modifier '['

"Makefile", line 273: Malformed conditional (defined(CC) && ${CC:[)
"Makefile", line 277: if-less endif
Unknown modifier '['

"Makefile", line 273: Malformed conditional (defined(CPP) && ${CPP:[)
"Makefile", line 277: if-less endif
Unknown modifier '['

"Makefile", line 273: Malformed conditional (defined(CXX) && ${CXX:[)
"Makefile", line 277: if-less endif
fmake: fatal errors encountered -- cannot continue

Cheers,

Antoine

>
> Modified: head/java/openjdk8/Makefile
> ==============================================================================
> --- head/java/openjdk8/Makefile Mon Dec 14 22:53:14 2015        (r403744)
> +++ head/java/openjdk8/Makefile Mon Dec 14 23:02:49 2015        (r403745)
> @@ -268,6 +268,18 @@ JDK_BUILD_TYPE=            release
>
>  AUTOCONF_ARGS= -I . -o generated-configure.sh generated-configure.ac
>
> +# XXX configure script rejects CC/CPP/CXX with absolute paths.
> +.for t in CC CPP CXX
> +.if defined(${t}) && ${${t}:[#]} == 1 && ${${t}:M/*}
> +BUILD_${t}=    ${${t}:C|.*/||g}
> +CONFIGURE_ENV+=        ${t}="${BUILD_${t}}"
> +TOOLS_DIR+=    ${${t}:S|/${BUILD_${t}}$||}
> +.endif
> +.endfor
> +.if defined(TOOLS_DIR)
> +CONFIGURE_ARGS+=       --with-tools-dir="${TOOLS_DIR:u:S/ /:/g}"
> +.endif
> +
>  .include <bsd.port.pre.mk>
>
>  .if ${ARCH:Marmv6*} || ${ARCH} == "i386"
>