From owner-freebsd-bugs@FreeBSD.ORG Mon Jul 18 16:10:09 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DF6EF1065676 for ; Mon, 18 Jul 2011 16:10:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id A33288FC15 for ; Mon, 18 Jul 2011 16:10:09 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p6IGA9YN017353 for ; Mon, 18 Jul 2011 16:10:09 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p6IGA99j017352; Mon, 18 Jul 2011 16:10:09 GMT (envelope-from gnats) Resent-Date: Mon, 18 Jul 2011 16:10:09 GMT Resent-Message-Id: <201107181610.p6IGA99j017352@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Henning Petersen Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 15924106564A for ; Mon, 18 Jul 2011 16:02:33 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 0546E8FC14 for ; Mon, 18 Jul 2011 16:02:33 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p6IG2WDs083843 for ; Mon, 18 Jul 2011 16:02:32 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p6IG2WpB083842; Mon, 18 Jul 2011 16:02:32 GMT (envelope-from nobody) Message-Id: <201107181602.p6IG2WpB083842@red.freebsd.org> Date: Mon, 18 Jul 2011 16:02:32 GMT From: Henning Petersen To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: bin/159011: Memory leak in bin/ed/buf.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jul 2011 16:10:10 -0000 >Number: 159011 >Category: bin >Synopsis: Memory leak in bin/ed/buf.c >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Jul 18 16:10:09 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Henning Petersen >Release: FreeBSD-current >Organization: >Environment: >Description: Memory leak in bin/ed/buf.c . >How-To-Repeat: >Fix: diff -u -r1.22 buf.c --- bin/ed/buf.c 30 Jun 2002 05:13:53 -0000 1.22 +++ bin/ed/buf.c 18 Jul 2011 13:19:28 -0000 @@ -94,6 +94,7 @@ ; if (s - cs >= LINECHARS) { errmsg = "line too long"; + free(lp); return NULL; } len = s - cs; @@ -102,6 +103,7 @@ if (fseeko(sfp, (off_t)0, SEEK_END) < 0) { fprintf(stderr, "%s\n", strerror(errno)); errmsg = "cannot seek temp file"; + free(lp); return NULL; } sfseek = ftello(sfp); @@ -112,6 +114,7 @@ sfseek = -1; fprintf(stderr, "%s\n", strerror(errno)); errmsg = "cannot write temp file"; + free(lp); return NULL; } lp->len = len; Patch attached with submission follows: diff -u -r1.22 buf.c --- bin/ed/buf.c 30 Jun 2002 05:13:53 -0000 1.22 +++ bin/ed/buf.c 18 Jul 2011 13:19:28 -0000 @@ -94,6 +94,7 @@ ; if (s - cs >= LINECHARS) { errmsg = "line too long"; + free(lp); return NULL; } len = s - cs; @@ -102,6 +103,7 @@ if (fseeko(sfp, (off_t)0, SEEK_END) < 0) { fprintf(stderr, "%s\n", strerror(errno)); errmsg = "cannot seek temp file"; + free(lp); return NULL; } sfseek = ftello(sfp); @@ -112,6 +114,7 @@ sfseek = -1; fprintf(stderr, "%s\n", strerror(errno)); errmsg = "cannot write temp file"; + free(lp); return NULL; } lp->len = len; >Release-Note: >Audit-Trail: >Unformatted: