From owner-svn-src-head@FreeBSD.ORG Thu Feb 26 22:17:08 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 166D57E3; Thu, 26 Feb 2015 22:17:08 +0000 (UTC) Received: from mail-ie0-x22f.google.com (mail-ie0-x22f.google.com [IPv6:2607:f8b0:4001:c03::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CDA52F2B; Thu, 26 Feb 2015 22:17:07 +0000 (UTC) Received: by iecat20 with SMTP id at20so22085580iec.12; Thu, 26 Feb 2015 14:17:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=0h0ZGn5g+OoLpRL3IMde/Lpl7+qgJipBVV5ONqPVDL4=; b=QtOP08YMFNEYdM0GkBJ5gfS9jd5JG/t9Lm3kVbR4xACE9scg6BCSw5dytKIErHLvbj DI0SNX7ui0++IjTZr8Lb2vZ3Em8pw/lV7SMVJfWEXXVbD3iNa5JCq9F8vEwiZyRoURcm peJ/halc+1TeqIRH4H9lmKAqz4+q9euZVvPOSlUj8x3ERVnck5ehodkNVB97twvgZQ6F OXobLfs9fdDh3P1JpWgSl51TQZha+KxRM7OgpIJ8ogosgbiioD+37DHmmMWGVoLz5qL9 n7SmRQOZMRcoSleQCe0a0fD9Z6Ie71n0rorKsrT5d063+FdylPZcssPDavx5EDr9A3IJ OWOw== MIME-Version: 1.0 X-Received: by 10.50.43.201 with SMTP id y9mr390804igl.6.1424989027120; Thu, 26 Feb 2015 14:17:07 -0800 (PST) Sender: adrian.chadd@gmail.com Received: by 10.36.17.66 with HTTP; Thu, 26 Feb 2015 14:17:07 -0800 (PST) In-Reply-To: <20150226212253.GE95752@strugglingcoder.info> References: <201502252159.t1PLx3UQ053872@svn.freebsd.org> <20150226212253.GE95752@strugglingcoder.info> Date: Thu, 26 Feb 2015 14:17:07 -0800 X-Google-Sender-Auth: zujWz_bbdrWcZ6druWqPF9_uaJY Message-ID: Subject: Re: svn commit: r279300 - in head/sys: kern sys From: Adrian Chadd To: hiren panchasara Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Feb 2015 22:17:08 -0000 I'm going to do this soon. Just need to get some help from doc@. I was waiting until I killed _pinned() so I wouldn't have to do it twice. Thanks (and keep poking me until i do it!) -a On 26 February 2015 at 13:22, hiren panchasara wrote: > On 02/25/15 at 09:59P, Adrian Chadd wrote: >> Author: adrian >> Date: Wed Feb 25 21:59:03 2015 >> New Revision: 279300 >> URL: https://svnweb.freebsd.org/changeset/base/279300 >> >> Log: >> Remove taskqueue_start_threads_pinned(); there's noa generic cpuset version of this. >> >> Sponsored by: Norse Corp, Inc. >> >> Modified: >> head/sys/kern/subr_taskqueue.c >> head/sys/sys/taskqueue.h >> >> Modified: head/sys/kern/subr_taskqueue.c >> ============================================================================== >> --- head/sys/kern/subr_taskqueue.c Wed Feb 25 21:44:53 2015 (r279299) >> +++ head/sys/kern/subr_taskqueue.c Wed Feb 25 21:59:03 2015 (r279300) >> @@ -659,30 +659,6 @@ taskqueue_start_threads_cpuset(struct ta >> return (error); >> } >> >> -int >> -taskqueue_start_threads_pinned(struct taskqueue **tqp, int count, int pri, >> - int cpu_id, const char *name, ...) >> -{ >> - cpuset_t mask; >> - va_list ap; >> - int error; >> - >> - /* >> - * In case someone passes in NOCPU, just fall back to the >> - * default behaviour of "don't pin". >> - */ >> - if (cpu_id != NOCPU) { >> - CPU_ZERO(&mask); >> - CPU_SET(cpu_id, &mask); >> - } >> - >> - va_start(ap, name); >> - error = _taskqueue_start_threads(tqp, count, pri, >> - cpu_id == NOCPU ? NULL : &mask, name, ap); >> - va_end(ap); >> - return (error); >> -} >> - >> static inline void >> taskqueue_run_callback(struct taskqueue *tq, >> enum taskqueue_callback_type cb_type) >> >> Modified: head/sys/sys/taskqueue.h >> ============================================================================== >> --- head/sys/sys/taskqueue.h Wed Feb 25 21:44:53 2015 (r279299) >> +++ head/sys/sys/taskqueue.h Wed Feb 25 21:59:03 2015 (r279300) >> @@ -74,10 +74,6 @@ int taskqueue_start_threads(struct taskq >> const char *name, ...) __printflike(4, 5); >> int taskqueue_start_threads_cpuset(struct taskqueue **tqp, int count, >> int pri, cpuset_t *mask, const char *name, ...) __printflike(5, 6); >> -int taskqueue_start_threads_pinned(struct taskqueue **tqp, int count, >> - int pri, int cpu_id, const char *name, >> - ...) __printflike(5, 6); >> - >> int taskqueue_enqueue(struct taskqueue *queue, struct task *task); >> int taskqueue_enqueue_timeout(struct taskqueue *queue, >> struct timeout_task *timeout_task, int ticks); >> > > Can you please update the manpage if you haven't already? > > Cheers, > Hiren