Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 26 Aug 2023 17:07:56 GMT
From:      Daniel Engberg <diizzy@FreeBSD.org>
To:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   git: 9549a20a0be5 - main - graphics/povray38: Remove NATIVE option and do some cleanups
Message-ID:  <202308261707.37QH7u7l048915@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by diizzy:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9549a20a0be5687d170dc419de5e5c8f1026af8c

commit 9549a20a0be5687d170dc419de5e5c8f1026af8c
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2023-08-26 17:03:12 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2023-08-26 17:03:18 +0000

    graphics/povray38: Remove NATIVE option and do some cleanups
    
    - Drop NATIVE option, utilize CPUTYPE instead which is supported using
      the framework via /etc/make.conf
    - Don't override optimization set by framework
    - Utilize framework helpers more and do some slight rearrangement
      for better readability and consistency with Porters Handbook
    
    PR:             273098
    Reviewed by:    Philipp Ost <bsd@philippost.de> (maintainer)
    Sponsored by:   Blinkinblox
---
 graphics/povray38/Makefile | 32 +++++++++++++-------------------
 1 file changed, 13 insertions(+), 19 deletions(-)

diff --git a/graphics/povray38/Makefile b/graphics/povray38/Makefile
index 1828c786dce3..fb01cfb733ab 100644
--- a/graphics/povray38/Makefile
+++ b/graphics/povray38/Makefile
@@ -16,27 +16,29 @@ LICENSE_FILE=	${WRKSRC}/LICENSE
 
 LIB_DEPENDS=	libboost_thread.so:devel/boost-libs
 
-USES=		compiler:c++11-lang gmake
+USES=		compiler:c++14-lang gmake
 USE_CXXSTD=	c++14
 
 GNU_CONFIGURE=	yes
-CONFIGURE_ARGS=	--program-transform-name='s/povray/${PKGBASE}/' \
-		COMPILED_BY=${MAINTAINER}
 
-VERSION_BASE=	${PORTVERSION:C/([0-9]+\.[0-9]+).*/\1/}
+WRKSRC=		${WRKDIR}/${DISTNAME}
+VERSION_BASE=	${DISTVERSION:C/([0-9]+\.[0-9]+).*/\1/}
+
 DATADIR=	${PREFIX}/share/${PORTNAME}-${VERSION_BASE}
 DOCSDIR=	${PREFIX}/share/doc/${PORTNAME}-${VERSION-BASE}
 ETCDIR=		${PREFIX}/etc/${PORTNAME}/${VERSION_BASE}
 EXAMPLESDIR=	${PREFIX}/share/examples/${PORTNAME}-${VERSION_BASE}
 
-OPTIONS_DEFINE=		DOCS EXAMPLES IO JPEG OPENEXR OPTIMIZED_CFLAGS PNG TIFF \
+CONFIGURE_ARGS=	--disable-optimiz \
+		--program-transform-name='s/povray/${PKGBASE}/' \
+		COMPILED_BY=${HOSTARCH}-portbld-${OPSYS:tl}-${OSREL:R}
+
+OPTIONS_DEFINE=		DOCS EXAMPLES IO JPEG OPENEXR PNG TIFF \
 			X11
 OPTIONS_DEFAULT=	JPEG PNG TIFF
 OPTIONS_SUB=		yes
 
-DOCS_DESC=	Install HTML documentation
-EXAMPLES_DESC=	Install example scenes
-IO_DESC=	Without I/O restrictions (security risk)
+IO_DESC=		Without I/O restrictions (security risk)
 
 IO_CONFIGURE_ON=	--disable-io-restrictions
 
@@ -45,27 +47,19 @@ JPEG_CONFIGURE_OFF=	--without-libjpeg
 
 OPENEXR_LIB_DEPENDS=	libImath.so:math/Imath \
 			libOpenEXR.so:graphics/openexr
-OPENEXR_CONFIGURE_ON=	--with-openexr
-OPENEXR_CONFIGURE_OFF=	--without-openexr
-
-OPTIMIZED_CFLAGS_CONFIGURE_OFF=	--disable-optimiz
-OPTIMIZED_CFLAGS_CFLAGS=	-march=native
+OPENEXR_CONFIGURE_WITH=	openexr
 
 PNG_LIB_DEPENDS=	libpng.so:graphics/png
-PNG_CONFIGURE_ON=	--with-libpng
-PNG_CONFIGURE_OFF=	--without-libpng
+PNG_CONFIGURE_WITH=	libpng
 
 TIFF_LIB_DEPENDS=	libtiff.so:graphics/tiff
-TIFF_CONFIGURE_ON=	--with-libtiff
-TIFF_CONFIGURE_OFF=	--without-libtiff
+TIFF_CONFIGURE_WITH=	libtiff
 
 X11_USES=		sdl xorg
 X11_USE=		SDL=sdl \
 			XORG=ice,sm,x11,xpm
 X11_CONFIGURE_OFF=	--without-x
 
-WRKSRC=		${WRKDIR}/${DISTNAME}
-
 .include <bsd.port.options.mk>
 
 .if !${PORT_OPTIONS:MJPEG} || !${PORT_OPTIONS:MPNG} || !${PORT_OPTIONS:MTIFF}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202308261707.37QH7u7l048915>