From owner-svn-src-head@freebsd.org Wed Jun 24 10:09:18 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2790234A2E6; Wed, 24 Jun 2020 10:09:18 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49sJld7507z3ckw; Wed, 24 Jun 2020 10:09:17 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [IPv6:2001:470:7a58:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "Let's Encrypt Authority X3" (verified OK)) (Authenticated sender: dim) by smtp.freebsd.org (Postfix) with ESMTPSA id DADF91EE39; Wed, 24 Jun 2020 10:09:17 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [10.10.156.45] (unknown [45.85.81.142]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id 774946E005; Wed, 24 Jun 2020 12:09:15 +0200 (CEST) From: Dimitry Andric Message-Id: <2FBF81D0-9EA3-4F46-9E3E-7EDE852962C1@FreeBSD.org> Content-Type: multipart/signed; boundary="Apple-Mail=_79D897FD-2ACA-4D1F-BA55-4EAD2EC975A3"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\)) Subject: Re: svn commit: r362333 - in head: contrib/flex contrib/flex/src usr.bin/lex usr.bin/lex/lib Date: Wed, 24 Jun 2020 12:09:03 +0200 In-Reply-To: Cc: Jung-uk Kim , src-committers , svn-src-all , svn-src-head To: Kyle Evans References: <202006181809.05II9G8p054025@repo.freebsd.org> X-Mailer: Apple Mail (2.3445.104.14) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jun 2020 10:09:18 -0000 --Apple-Mail=_79D897FD-2ACA-4D1F-BA55-4EAD2EC975A3 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On 24 Jun 2020, at 02:41, Kyle Evans wrote: > > On Thu, Jun 18, 2020 at 1:09 PM Jung-uk Kim wrote: >> >> Author: jkim >> Date: Thu Jun 18 18:09:16 2020 >> New Revision: 362333 >> URL: https://svnweb.freebsd.org/changeset/base/362333 >> >> Log: >> MFV: r362286 >> >> Merge flex 2.6.4. >> > > Hi, > > I'm looking at getting amd64 world buildable again by gcc6; this seems > to give it some gas: > > /usr/src/contrib/flex/src/main.c: In function 'check_options': > /usr/src/contrib/flex/src/main.c:347:14: error: assignment discards > 'const' qualifier from pointer target type > [-Werror=discarded-qualifiers] > if ((slash = strrchr(M4, '/')) != NULL) { > > The following trivial patch seems to make gcc6 happy again. This is a strange one. As gcc6 has been removed from ports, I had to resort to an older 12-STABLE box which still had it, but no matter what I try, I cannot get the warning that is being produced by the CI system. What does it do differently? Also, the warning is indeed bogus, as strrchr() returns a non-const char pointer. As I can't reproduce it, I also can't verify which gcc version fixes the bogus warning. -Dimitry --Apple-Mail=_79D897FD-2ACA-4D1F-BA55-4EAD2EC975A3 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.2 iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCXvMmQAAKCRCwXqMKLiCW o5lWAKCAZDl/tBqgKpzUFos58HcuwdhHtwCeOW/37V5em/h8Npgv+/IyyEJ++rI= =VwQf -----END PGP SIGNATURE----- --Apple-Mail=_79D897FD-2ACA-4D1F-BA55-4EAD2EC975A3--