From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Jun 11 12:40:08 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C03171065690 for ; Wed, 11 Jun 2008 12:40:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 9E8628FC36 for ; Wed, 11 Jun 2008 12:40:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m5BCe8Aj034584 for ; Wed, 11 Jun 2008 12:40:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m5BCe8s8034583; Wed, 11 Jun 2008 12:40:08 GMT (envelope-from gnats) Resent-Date: Wed, 11 Jun 2008 12:40:08 GMT Resent-Message-Id: <200806111240.m5BCe8s8034583@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Ed Schouten Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D09751065675 for ; Wed, 11 Jun 2008 12:34:23 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:610:652::211]) by mx1.freebsd.org (Postfix) with ESMTP id 96F758FC31 for ; Wed, 11 Jun 2008 12:34:23 +0000 (UTC) (envelope-from ed@hoeg.nl) Received: by palm.hoeg.nl (Postfix, from userid 1000) id 2E9111CC1A; Wed, 11 Jun 2008 14:31:48 +0200 (CEST) Message-Id: <20080611123148.2E9111CC1A@palm.hoeg.nl> Date: Wed, 11 Jun 2008 14:31:48 +0200 (CEST) From: Ed Schouten To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/124484: [Patch] comms/conserver: don't use sgtty X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Ed Schouten List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jun 2008 12:40:08 -0000 >Number: 124484 >Category: ports >Synopsis: [Patch] comms/conserver: don't use sgtty >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jun 11 12:40:08 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Ed Schouten >Release: FreeBSD 6.3-STABLE i386 >Organization: >Environment: System: FreeBSD palm.hoeg.nl 6.3-STABLE FreeBSD 6.3-STABLE #0: Wed Jun 4 08:56:01 CEST 2008 ed@palm.hoeg.nl:/usr/obj/usr/src/sys/PALM i386 >Description: The comms/conserver port still uses the sgtty programming interface. This interface is going away soon, which means we have to switch this application to use termios. conserver already supports termios, but it is disabled on FreeBSD. Using sgtty is bad; it doesn't work when COMPAT_43TTY is disabled in the kernel configuration file. >How-To-Repeat: >Fix: Store the following patch in the `files' directory. It enables termios and makes it compile as well. --- etc/autologin/autologin.c +++ etc/autologin/autologin.c @@ -41,7 +41,6 @@ #if USE_TERMIOS #include -#include #else #if USE_TERMIO @@ -443,11 +442,11 @@ /* NOTREACHED */ } #endif - n_tio.c_iflag &= ~(IGNCR|IUCLC); + n_tio.c_iflag &= ~(IGNCR); n_tio.c_iflag |= ICRNL|IXON|IXANY; - n_tio.c_oflag &= ~(OLCUC|ONOCR|ONLRET|OFILL|NLDLY|CRDLY|TABDLY|BSDLY); - n_tio.c_oflag |= OPOST|ONLCR|TAB3; - n_tio.c_lflag &= ~(XCASE|NOFLSH|ECHOK|ECHONL); + n_tio.c_oflag &= ~(ONOCR|ONLRET); + n_tio.c_oflag |= OPOST|ONLCR|OXTABS; + n_tio.c_lflag &= ~(NOFLSH|ECHOK|ECHONL); n_tio.c_lflag |= ISIG|ICANON|ECHO; n_tio.c_cc[VEOF] = '\004'; /* ^D */ n_tio.c_cc[VEOL] = '\000'; /* EOL */ --- etc/autologin/machine.h +++ etc/autologin/machine.h @@ -38,7 +38,7 @@ #define USE_TERMIO (defined(ETA10)||defined(V386)) #endif #if !defined(USE_TERMIOS) -#define USE_TERMIOS (defined(HPUX)||defined(SUN5)||defined(PTX)||defined(IRIX5)||defined(LINUX)) +#define USE_TERMIOS (defined(HPUX)||defined(SUN5)||defined(PTX)||defined(IRIX5)||defined(LINUX)||defined(FREEBSD)) #endif #if !defined(USE_TCBREAK) #define USE_TCBREAK (defined(SUN4)||defined(PTX)) @@ -66,7 +66,7 @@ #endif #if !defined(USE_TC) -#define USE_TC (defined(EPIX)||defined(IBMR2)||defined(V386)||defined(S81)||defined(PARAGON)) +#define USE_TC (defined(EPIX)||defined(IBMR2)||defined(V386)||defined(S81)||defined(PARAGON)||defined(FREEBSD)) #endif #if !defined(HAVE_GETUSERATTR) @@ -74,7 +74,7 @@ #endif #if !defined(USE_IOCTL) -#define USE_IOCTL (defined(V386)||defined(S81)||defined(NETBSD)||defined(FREEBSD)) +#define USE_IOCTL (defined(V386)||defined(S81)||defined(NETBSD)) #endif @@ -127,7 +127,6 @@ #if FREEBSD #include #include -#include #define setsid() getpid() #else >Release-Note: >Audit-Trail: >Unformatted: