From owner-svn-src-head@FreeBSD.ORG Wed Apr 20 13:05:49 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CE6FD106566B; Wed, 20 Apr 2011 13:05:49 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:130:3ffc::401:25]) by mx1.freebsd.org (Postfix) with ESMTP id 86B348FC14; Wed, 20 Apr 2011 13:05:49 +0000 (UTC) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id AB5EB25D37C7; Wed, 20 Apr 2011 13:05:48 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id 9E0D6159D540; Wed, 20 Apr 2011 13:05:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id RYhuAueWdlIx; Wed, 20 Apr 2011 13:05:46 +0000 (UTC) Received: from nv.sbone.de (nv.sbone.de [IPv6:fde9:577b:c1a9:31::2013:138]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 37E49159D565; Wed, 20 Apr 2011 13:05:46 +0000 (UTC) Date: Wed, 20 Apr 2011 13:05:45 +0000 (UTC) From: "Bjoern A. Zeeb" To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org In-Reply-To: <201104201258.p3KCwUVo049188@svn.freebsd.org> Message-ID: References: <201104201258.p3KCwUVo049188@svn.freebsd.org> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Subject: Re: svn commit: r220885 - head/sys/conf X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2011 13:05:49 -0000 On Wed, 20 Apr 2011, Bjoern A. Zeeb wrote: > Author: bz > Date: Wed Apr 20 12:58:30 2011 > New Revision: 220885 > URL: http://svn.freebsd.org/changeset/base/220885 > > Log: > Compile in in_cksum* implementations for both IPv6 and IPv6. IPv4 and IPv6 as Erwin noticed. > While in_pseudo() etc. is often used in offloading feature support, > in_cksum() is mostly used to fix some broken hardware. > > Keeping both around for the moment allows us to compile NIC drivers > even in an IPv6 only environment without the need to mangle them > with #ifdef INETs in a way they are not prepared for. This will > leave some dead code paths that will not be exercised for IPv6. Note that the changes coming soon removing the inet dependency from drivers will break no-INET && no-INET6 (no-IP) kernels when those drivers are included which is kind of a step backwards but we don't have many people compiling no-IP kernels with the NIC drivers these days (apart from my universe builds) I guess. Sam had concerns about the inet dependency on drivers months back when I added them and he was right. The real fix is really to add the proper #ifdefs to the drivers in my view, in which cases i.e. TSO4 would not be announced or processed, etc. when there is no INET in the kernel, etc. But for all that to work and happen we'll need a better plan on how to handle all these features rightish in the future. We have way too much copy and paste in our drivers for all that. I'll defer this discussion though for a bit later in the year. > Reviewed by: gnn > Sponsored by: The FreeBSD Foundation > Sponsored by: iXsystems > MFC after: 3 days > > Modified: > head/sys/conf/files.amd64 > head/sys/conf/files.arm > head/sys/conf/files.i386 > head/sys/conf/files.ia64 > head/sys/conf/files.mips > head/sys/conf/files.pc98 > head/sys/conf/files.powerpc > head/sys/conf/files.sparc64 > head/sys/conf/files.sun4v -- Bjoern A. Zeeb You have to have visions! Stop bit received. Insert coin for new address family.