From owner-freebsd-emulation@FreeBSD.ORG  Wed May  3 14:27:39 2006
Return-Path: <owner-freebsd-emulation@FreeBSD.ORG>
X-Original-To: freebsd-emulation@freebsd.org
Delivered-To: freebsd-emulation@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2F73B16A45B
	for <freebsd-emulation@freebsd.org>;
	Wed,  3 May 2006 14:27:39 +0000 (UTC)
	(envelope-from ambrisko@ambrisko.com)
Received: from mail2.ambrisko.com (mail2.ambrisko.com [64.174.51.44])
	by mx1.FreeBSD.org (Postfix) with ESMTP id CF9E943D45
	for <freebsd-emulation@freebsd.org>;
	Wed,  3 May 2006 14:27:38 +0000 (GMT)
	(envelope-from ambrisko@ambrisko.com)
Received: from server2.ambrisko.com (HELO www.ambrisko.com) ([192.168.1.2])
	by mail2.ambrisko.com with ESMTP; 03 May 2006 07:26:43 -0700
Received: from ambrisko.com (localhost [127.0.0.1])
	by www.ambrisko.com (8.12.11/8.12.11) with ESMTP id k43ERcQ6083924;
	Wed, 3 May 2006 07:27:38 -0700 (PDT)
	(envelope-from ambrisko@ambrisko.com)
Received: (from ambrisko@localhost)
	by ambrisko.com (8.12.11/8.12.11/Submit) id k43ERcUI083923;
	Wed, 3 May 2006 07:27:38 -0700 (PDT) (envelope-from ambrisko)
From: Doug Ambrisko <ambrisko@ambrisko.com>
Message-Id: <200605031427.k43ERcUI083923@ambrisko.com>
In-Reply-To: <20060503105431.k8rmf62jlwoscwgc@netchild.homeip.net>
To: Alexander Leidinger <Alexander@Leidinger.net>
Date: Wed, 3 May 2006 07:27:38 -0700 (PDT)
X-Mailer: ELM [version 2.4ME+ PL94b (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII
Cc: freebsd-emulation@freebsd.org
Subject: Re: Linux emulation enhancement to emulate device nodes and some
 SCSI stuff
X-BeenThere: freebsd-emulation@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Development of Emulators of other operating systems
	<freebsd-emulation.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-emulation>
List-Post: <mailto:freebsd-emulation@freebsd.org>
List-Help: <mailto:freebsd-emulation-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 03 May 2006 14:27:39 -0000

Alexander Leidinger writes:
| Quoting Doug Ambrisko <ambrisko@ambrisko.com> (from Thu, 27 Apr 2006  
| 14:48:28 -0700 (PDT)):
| 
| > To get the LSI RAID SAS to work under Linux emulation we need to emulate
| > more of Linux type stuff.  I've put patches up at:
| > 	http://www.ambrisko.com/doug/linux.patches
| 
| In case you didn't got any responses: go ahead, we don't have an  
| active linuoxlator guru ATM.
| 
| Some generic comments (only a *quick* C-level review, not a  
| design/concept-level review):
| ---snip--
| @@ -470,7 +522,9 @@ linux_fstat64(struct thread *td, struct
|   #endif
| 
|   	error = kern_fstat(td, args->fd, &buf);
| +	translate_fd_major_minor(td, args->fd, &buf);
|   	if (!error)
| +		translate_fd_major_minor(td, args->fd, &buf);
|   		error = stat64_copyout(&buf, args->statbuf);
| ---snip---
| 
| Bug, missing {} for the "if".

Good catch.  The error is that I pasted in a 2nd bogus
	translate_fd_major_minor(td, args->fd, &buf);
I fixed that.

Thanks for looking at it.  I'll check on my make universe and check it
in if that worked okay.

Doug A.