From owner-freebsd-current Thu Mar 16 7:40: 5 2000 Delivered-To: freebsd-current@freebsd.org Received: from critter.freebsd.dk (wandering-wizard.cybercity.dk [212.242.43.150]) by hub.freebsd.org (Postfix) with ESMTP id E77DC37BBB5 for ; Thu, 16 Mar 2000 07:39:57 -0800 (PST) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost.freebsd.dk [127.0.0.1]) by critter.freebsd.dk (8.9.3/8.9.3) with ESMTP id QAA02069; Thu, 16 Mar 2000 16:39:43 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Julian Elischer Cc: current@freebsd.org Subject: Re: B_WRITE cleanup patch, please test! In-reply-to: Your message of "Thu, 16 Mar 2000 07:27:38 PST." <38D0FD6A.167EB0E7@elischer.org> Date: Thu, 16 Mar 2000 16:39:43 +0100 Message-ID: <2067.953221183@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <38D0FD6A.167EB0E7@elischer.org>, Julian Elischer writes: >1/ I think the removal of IPSEC from LINT is by mistake in this patch yes, that is a mistake. >2/ The change of separating buffer management from IO management >is long overdue and the introduction of b_iocmd is a good first step >for this. The selection of values is in my mind arguable either way. > >As the field is an 'op-code' I would have chosen the values to be: >#define BIO_NOP 0 >#define BIO_READ 1 >#define BIO_WRITE 2 >#define BIO_DELETE 3 I decided to use binary values, because there is a simple arithmetic test for "exactly one bit set" (See BUF_STRATEGY). I wanted to catch as many bogus cases of B_WRITE zeroness being abused as possible, ie, people initializing b_flags = 0 knowing that would give them a write. >4/ does this produce compatibility problems with any 3rd party code? This is 5.0-CURRENT, they will have to adopt to much worse things before it becomes 5.0-RELEASE. -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop." FreeBSD -- It will take a long time before progress goes too far! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message