Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 15 Jun 2012 17:50:00 +0200
From:      "Julian H. Stacey" <jhs@berklix.com>
To:        johans@FreeBSD.org
Cc:        ports@FreeBSD.org, "Julian H. Stacey" <jhs@berklix.com>
Subject:   Mk macros & print/texinfo/distinfo variant SHA256 SIZE
Message-ID:  <201206151550.q5FFo0Gh044990@fire.js.berklix.net>

next in thread | raw e-mail | index | archive | help
Hi johans@FreeBSD.org
& cc ports@
A 9.0-RELEASE ports fails on
	cd print/texinfo ; make fetch
unless one imports newer values from current, (as I did in my
 http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/ports/gen/print/texinfo/distinfo.REL=ALL.diff )

But periodicaly patching distinfo with new SHA256 & SIZE 
is not a good solution as
- We can only update values in /pub/FreeBSD/branches/-current/ports/
  (as done already), but
- The values are frozen at release time to whatever is exported by
	cvs -Q -R export -r RELEASE_8_0_0  ports 
- Periodically internet contents of 2 files texinfo.tex & texi2dvi will change
  while names remains the same, 
- Then along comes a user, trying to make fetch from a release, & it fails.

So how best to modify Makefile to not break on size & sha256 of
some but not all files ?

The question can't be unique to this port, would a half way house
be nice ?  An Mk/bsd.port.mk macro to sniff at & warn but not error
if certain values are wrong ?  To support some shorter named version of eg:

  WARN_IF_NOT_SHA256 (texinfo.tex) = f506a97fe0ea0388c9b29653bd9b9ed8e188d3d649a9e9485e2e051bba47496e
  WARN_IF_NOT_SIZE (texinfo.tex) = 321252
  WARN_IF_NOT_SHA256 (texi2dvi) = bf6fc2d85b52cde8e7919b5a379804a3d1eeaa95cb781c7daf79fd5f3cc8e6be
  WARN_IF_NOT_SIZE (texi2dvi) = 58102

I see Mk has:
	NO_CHECKSUM is a user variable and is not to be set in a
	port's Makefile.
It's also too crude for this, as
	- the checksum of texinfo-4.13.tar.gz is invariant & should be checked.	
	- if one let loose eg
		cd /some...release/ports ; make fetch
	  one would want mots other checksums checked.

current Mk/bsd.port.mk has
# DISABLE_SIZE  - Do not check the size of a distfile even if the SIZE field
#                 has been specified in distinfo.  This is useful
#                 when using an alternate FETCH_CMD.

I see no analagous
  DISABLE_SHA256
  DISABLE_CHECKSUM

Thoughts ?

Cheers,
Julian
-- 
Julian Stacey, BSD Unix Linux C Sys Eng Consultants Munich http://berklix.com
 Reply below not above, cumulative like a play script, & indent with "> ".
 Format: Plain text. Not HTML, multipart/alternative, base64, quoted-printable.
	Mail from @yahoo dumped @berklix.  http://berklix.org/yahoo/



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201206151550.q5FFo0Gh044990>