From owner-freebsd-ports@FreeBSD.ORG Fri Jun 15 15:50:30 2012 Return-Path: Delivered-To: ports@FreeBSD.org Received: from mx1.freebsd.org (unknown [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7E0511065673; Fri, 15 Jun 2012 15:50:30 +0000 (UTC) (envelope-from jhs@berklix.com) Received: from tower.berklix.org (tower.berklix.org [83.236.223.114]) by mx1.freebsd.org (Postfix) with ESMTP id E71218FC14; Fri, 15 Jun 2012 15:50:29 +0000 (UTC) Received: from mart.js.berklix.net (p5DCBDEB4.dip.t-dialin.net [93.203.222.180]) (authenticated bits=0) by tower.berklix.org (8.14.2/8.14.2) with ESMTP id q5FFoR1k017623; Fri, 15 Jun 2012 15:50:28 GMT (envelope-from jhs@berklix.com) Received: from fire.js.berklix.net (fire.js.berklix.net [192.168.91.41]) by mart.js.berklix.net (8.14.3/8.14.3) with ESMTP id q5FFoNww066847; Fri, 15 Jun 2012 17:50:23 +0200 (CEST) (envelope-from jhs@berklix.com) Received: from fire.js.berklix.net (localhost [127.0.0.1]) by fire.js.berklix.net (8.14.4/8.14.4) with ESMTP id q5FFo0Gh044990; Fri, 15 Jun 2012 17:50:06 +0200 (CEST) (envelope-from jhs@fire.js.berklix.net) Message-Id: <201206151550.q5FFo0Gh044990@fire.js.berklix.net> To: johans@FreeBSD.org From: "Julian H. Stacey" Organization: http://berklix.com BSD Linux Unix Consultancy, Munich Germany User-agent: EXMH on FreeBSD http://www.berklix.com/free/ X-URL: http://www.berklix.com/~jhs/cv/ Date: Fri, 15 Jun 2012 17:50:00 +0200 Sender: jhs@berklix.com Cc: ports@FreeBSD.org, "Julian H. Stacey" Subject: Mk macros & print/texinfo/distinfo variant SHA256 SIZE X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jun 2012 15:50:30 -0000 Hi johans@FreeBSD.org & cc ports@ A 9.0-RELEASE ports fails on cd print/texinfo ; make fetch unless one imports newer values from current, (as I did in my http://berklix.com/~jhs/src/bsd/fixes/FreeBSD/ports/gen/print/texinfo/distinfo.REL=ALL.diff ) But periodicaly patching distinfo with new SHA256 & SIZE is not a good solution as - We can only update values in /pub/FreeBSD/branches/-current/ports/ (as done already), but - The values are frozen at release time to whatever is exported by cvs -Q -R export -r RELEASE_8_0_0 ports - Periodically internet contents of 2 files texinfo.tex & texi2dvi will change while names remains the same, - Then along comes a user, trying to make fetch from a release, & it fails. So how best to modify Makefile to not break on size & sha256 of some but not all files ? The question can't be unique to this port, would a half way house be nice ? An Mk/bsd.port.mk macro to sniff at & warn but not error if certain values are wrong ? To support some shorter named version of eg: WARN_IF_NOT_SHA256 (texinfo.tex) = f506a97fe0ea0388c9b29653bd9b9ed8e188d3d649a9e9485e2e051bba47496e WARN_IF_NOT_SIZE (texinfo.tex) = 321252 WARN_IF_NOT_SHA256 (texi2dvi) = bf6fc2d85b52cde8e7919b5a379804a3d1eeaa95cb781c7daf79fd5f3cc8e6be WARN_IF_NOT_SIZE (texi2dvi) = 58102 I see Mk has: NO_CHECKSUM is a user variable and is not to be set in a port's Makefile. It's also too crude for this, as - the checksum of texinfo-4.13.tar.gz is invariant & should be checked. - if one let loose eg cd /some...release/ports ; make fetch one would want mots other checksums checked. current Mk/bsd.port.mk has # DISABLE_SIZE - Do not check the size of a distfile even if the SIZE field # has been specified in distinfo. This is useful # when using an alternate FETCH_CMD. I see no analagous DISABLE_SHA256 DISABLE_CHECKSUM Thoughts ? Cheers, Julian -- Julian Stacey, BSD Unix Linux C Sys Eng Consultants Munich http://berklix.com Reply below not above, cumulative like a play script, & indent with "> ". Format: Plain text. Not HTML, multipart/alternative, base64, quoted-printable. Mail from @yahoo dumped @berklix. http://berklix.org/yahoo/