From owner-freebsd-current@FreeBSD.ORG Tue Dec 20 22:44:58 2011 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 92F681065675 for ; Tue, 20 Dec 2011 22:44:58 +0000 (UTC) (envelope-from mdf356@gmail.com) Received: from mail-pw0-f54.google.com (mail-pw0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id 68E578FC0C for ; Tue, 20 Dec 2011 22:44:58 +0000 (UTC) Received: by pbcc3 with SMTP id c3so5384283pbc.13 for ; Tue, 20 Dec 2011 14:44:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=9+0yvq1Xq7oGlhY7rWhTUclRGlw+yyWi+L3TTCz9aXc=; b=WGzDojvab81lifekKtlmNs6qq40bcvYrhEzTdNua1JuXw5xappXVUg0bMbRd2aFlQe ENOwXp6Q/nmo1l9AYTGxrk3EuMHh1U/yKXq7iwZSSRXAcbulvCzymLc9JZk3vqHlmB+k NlNWBgaU0rpdeo3b6WjW/9LXT08chAHCUtpHI= MIME-Version: 1.0 Received: by 10.68.213.41 with SMTP id np9mr6295989pbc.71.1324419538520; Tue, 20 Dec 2011 14:18:58 -0800 (PST) Sender: mdf356@gmail.com Received: by 10.68.55.136 with HTTP; Tue, 20 Dec 2011 14:18:58 -0800 (PST) In-Reply-To: <201112201649.06265.jhb@freebsd.org> References: <201112201649.06265.jhb@freebsd.org> Date: Tue, 20 Dec 2011 14:18:58 -0800 X-Google-Sender-Auth: ywbe_POGLVZUiOxaacEltPOAQxY Message-ID: From: mdf@FreeBSD.org To: John Baldwin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: Robert Watson , current@freebsd.org Subject: Re: extattr_set_*() return type X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2011 22:44:58 -0000 On Tue, Dec 20, 2011 at 1:49 PM, John Baldwin wrote: > Hmm, if these functions are expected to operate like 'write(2)' and are > supposed to return the number of bytes written, shouldn't their return va= lue > be 'ssize_t' instead of 'int'? =A0It looks like the system calls themselv= es > already do the right thing in setting td_retval[] (they assign a ssize_t = to it > and td_retval[0] can hold a ssize_t on all of our current platforms). =A0= It > would seem that the only change would be to the header and probably > syscalls.master. =A0I guess this would require a symver bump to fix thoug= h. An extended attribute larger than 2GB is a programming abuse, though. Technically int may not be 32 bits but it is on all supported platforms now. Cheers, matthew