From owner-cvs-all Wed Jan 16 16:24:24 2002 Delivered-To: cvs-all@freebsd.org Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by hub.freebsd.org (Postfix) with ESMTP id DBF6237B402; Wed, 16 Jan 2002 16:24:18 -0800 (PST) Received: by elvis.mu.org (Postfix, from userid 1192) id AF32210DE00; Wed, 16 Jan 2002 16:24:18 -0800 (PST) Date: Wed, 16 Jan 2002 16:24:18 -0800 From: Alfred Perlstein To: John Baldwin Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/kern sys_generic.c Message-ID: <20020116162418.P26067@elvis.mu.org> References: <200201162133.g0GLXfA36921@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from jhb@FreeBSD.org on Wed, Jan 16, 2002 at 04:00:36PM -0800 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * John Baldwin [020116 16:01] wrote: > > On 16-Jan-02 Alfred Perlstein wrote: > > alfred 2002/01/16 13:33:41 PST > > > > Modified files: > > sys/kern sys_generic.c > > Log: > > Fix giant handling in pwrite(2), I forgot to release it when finishing > > the syscall. > > Uh, this isn't correct. fdrop() can call fo_close() can call down into VFS > and do a vrele(), so fdrop() still needs Giant. If you aren't holding Giant > across fdrop() in a few places that might explain the vput(0x0) panics. Ugh, I'll get to this tonight unless you want to tackle it now. -Alfred To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message