From owner-freebsd-arch@FreeBSD.ORG Mon Mar 22 11:34:20 2010 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A9F6D106564A; Mon, 22 Mar 2010 11:34:20 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 488A28FC1D; Mon, 22 Mar 2010 11:34:20 +0000 (UTC) Received: from outgoing.leidinger.net (pD954FF67.dip.t-dialin.net [217.84.255.103]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id 2FD2F844B26; Mon, 22 Mar 2010 12:34:12 +0100 (CET) Received: from webmail.leidinger.net (webmail.leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id 7907251B5; Mon, 22 Mar 2010 12:34:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=Leidinger.net; s=outgoing-alex; t=1269257648; bh=3P/QKcutTni5aiOOTSuHpYaLoMmfe8J8M93A+9gcekY=; h=Message-ID:Date:From:To:Cc:Subject:References:In-Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding; b=MmtWMdAM1uWYDfbAgkkTw7eqptZfkOyHUitN2YlQcuQAvkKa++yrZ9npxZEtKXchu a2rKc2jryVXoXZveR2p+cazpRFI8C9Kp58NmwydAd5zTaq/dtXsnaYgRlaTc+J+SQh 8vFq2taAJ1KomFjnRIOpAO+JsXdEBVVTYFVNcTsfViSKx6aTb8yGYwwCY4FC8OA0SK 7Nlkv9oNxkdWMmkZz1VsrRlKciibEEmbSLsZWNRUyjw1gxHeeq4hwP/JgnZtTfy/GS oi0sN3HpIpItKyHg3fXUwY5Rl323Jy5Mp2YDgUZ8m9ZQFGFUMF4KUHfArZ+bLQ/FVd H2QO8R4xhFFOw== Received: (from www@localhost) by webmail.leidinger.net (8.14.3/8.13.8/Submit) id o2MBY8nF032060; Mon, 22 Mar 2010 12:34:08 +0100 (CET) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Mon, 22 Mar 2010 12:34:08 +0100 Message-ID: <20100322123408.16671ijbvmcyux80@webmail.leidinger.net> Date: Mon, 22 Mar 2010 12:34:08 +0100 From: Alexander Leidinger To: John Baldwin References: <20100310113422.95932h10tv1qh2o0@webmail.leidinger.net> <201003100812.29749.jhb@freebsd.org> In-Reply-To: <201003100812.29749.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Dynamic Internet Messaging Program (DIMP) H3 (1.1.4) X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: 2FD2F844B26.BB2C7 X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=-1.44, required 6, autolearn=disabled, ALL_TRUSTED -1.44, DKIM_SIGNED 0.00, DKIM_VERIFIED -0.00) X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1269862454.66797@2XXAxS3+6owyTeDP5PLY2g X-EBL-Spam-Status: No Cc: "Robert N. M. Watson" , freebsd-arch@freebsd.org Subject: CTF patch for testing/review (was: Re: is dtrace usable?) X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Mar 2010 11:34:20 -0000 Redirecting from stable@ to arch@... Quoting John Baldwin (from Wed, 10 Mar 2010 08:12:29 -0500): > On Wednesday 10 March 2010 5:34:22 am Alexander Leidinger wrote: >> Quoting "Robert N. M. Watson" (from Tue, 9 Mar >> 2010 16:39:09 +0000): >> >> > >> > On Mar 9, 2010, at 2:16 PM, Alexander Leidinger wrote: >> > >> >>> From this you can see that sys.mk is included and parsed before > 'Makefile', >> >>> so the WITH_CTF=yes is not set until after sys.mk has been parsed. >> >> >> >> I think we need to find a different solution for this. The need to >> >> specify WITH_CTF at the command line is very error prone. :( >> > >> > You are neither the first person to have made this observation, nor >> > the first person to have failed to propose a solution in the form of >> > a patch :-). Ok, here is the proposal in form of a patch. :-) http://www.leidinger.net/test/ctf.diff > Unfortunately the ctf stuff breaks static binaries. I think that if > that were > fixed we would simply enable it by default and be done. The patch is: - enabling CTF stuff by default for the kernel - allows to disable the CTF stuff for the kernel by defining NO_CTF - *not* enabling the CTF stuff by default for libs and progs (if someone tells me how to distinguish the build for static stuff from dynamic stuff, I can have a look to enable it for the dynamic case) - allows to enable the CTF stuff for the userland by defining WITH_CTF as before I have not tested what this patch is doing to bootblocks or the loader (= stuff within /sys/ which is not the kernel or kernel modules). In case it hurts, we can add NO_CTF to the corresponding Makefiles. I do not have a scratch system around ATM, so any report from installing a bootblock (gpt/zfs/normal/whatever) after a buildworld/installworld is welcome. In case there are people which want to moan that I moved a conditional from make to shell: - the shell stuff is using build-ins - feel free to provide patches which makes it work with make-conditionals (I failed, and I tried several things before switching to shell stuff) In case people moan about the inverse logic I use in the shell conditional: - the current way is working for all cases and does not require to ignore an error in make ("make CTFCONVERT=false" correctly errors out) - test your proposal before you moan (worst case: all parmutations of WITH_CTF, NO_CTF, CTFCONVERT=false) - if the majority wants to have the '-' in front of a similar positive-logic command, I do not object, but this will ignore real errors from ctf{convert|merge} (whatever those could be) Bye, Alexander. -- The real problem with hunting elephants carrying the decoys. http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137