From owner-svn-src-head@FreeBSD.ORG Thu Mar 8 19:26:30 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 10DEA106564A; Thu, 8 Mar 2012 19:26:30 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 9C9528FC15; Thu, 8 Mar 2012 19:26:29 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) by cyrus.watson.org (Postfix) with ESMTPSA id 5565A46B0A; Thu, 8 Mar 2012 14:26:29 -0500 (EST) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id B8E72B94D; Thu, 8 Mar 2012 14:26:28 -0500 (EST) From: John Baldwin To: "Jung-uk Kim" Date: Thu, 8 Mar 2012 11:05:32 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p10; KDE/4.5.5; amd64; ; ) References: <201203051953.q25JrIS1002269@svn.freebsd.org> <201203071700.21259.jkim@FreeBSD.org> In-Reply-To: <201203071700.21259.jkim@FreeBSD.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201203081105.32334.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Thu, 08 Mar 2012 14:26:28 -0500 (EST) Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , src-committers@freebsd.org Subject: Re: svn commit: r232570 - head/sys/boot/i386/boot2 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Mar 2012 19:26:30 -0000 On Wednesday, March 07, 2012 5:00:19 pm Jung-uk Kim wrote: > On Monday 05 March 2012 02:53 pm, John Baldwin wrote: > > Author: jhb > > Date: Mon Mar 5 19:53:17 2012 > > New Revision: 232570 > > URL: http://svn.freebsd.org/changeset/base/232570 > > > > Log: > > Fix boot2 to handle boot config files that only contain a custom > > path to a loader or kernel. Specifically, kname cannot be pointed > > at cmd[] since it's value is change to be an empty string after the > > initial call to parse, and cmd[]'s value can be changed (thus > > losing a prior setting for kname) due to user input at the boot > > prompt. While here, ensure that that initial boot config file text > > is nul-terminated, that ops is initialized to zero, and that kname > > is always initialized to a valid string. > > As many people pointed out, Clang overflows boot2 again after this > commit. Long long time ago, I asked this question on arch@: > > http://docs.freebsd.org/cgi/mid.cgi?200509081418.47794.jkim > > Why can't we do that now? Can't we build separate ufs1-only and > ufs2-only boot2's, at least? Having ufs1+ufs2 boot block is great > but I see very little benefit to support that in 2012. :-/ As I said on the reply to current@, I think having separate boot blocks will be a headache and PITA for our users. Let's see if we can get boot2 to fit without breaking functionality first. It is a shame that gcc outperforms clang so drastically in this case (gcc's boot2 is about 250 bytes smaller than clang's). -- John Baldwin