From nobody Tue Apr 28 16:54:40 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g4mkk3ZBHz6bmd8 for ; Tue, 28 Apr 2026 16:54:54 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g4mkj5J7Jz3YDL for ; Tue, 28 Apr 2026 16:54:53 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; arc=pass ("google.com:s=arc-20240605:i=1"); dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of adrian.chadd@gmail.com designates 209.85.219.41 as permitted sender) smtp.mailfrom=adrian.chadd@gmail.com Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-8acb856a674so512486d6.0 for ; Tue, 28 Apr 2026 09:54:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1777395292; cv=none; d=google.com; s=arc-20240605; b=TIDu12oFYL1OGL6mz7vU+MJlyLesBNFSATgsTTK8MuN05nr++XPoYlv1zaajKvFr1/ fkq9WKSq2dg+JxeZ1wlsFLwC+hbEFsrP9wkadAdTcyLoLO1Jb5OGez0vkzAsvKEtz9KB ubpnivwai9GkU5X3NXODmbNS1dVlZxCGqOwl6uYxZ2Z/rcG1tny7DhPShiMqILp5nrIX S0HdZXvYVJypiFcDDkfbo1vco8zAITrWEVbS4jp+QIv1sU5ZrSFACfbnHegt37Iij52+ OMi2xhZkpbRGeBpZg0uG3IrY7pkDiUYdp4UgYIrmFLTnV5+08seHISoDJpEhdvEbJjv5 SWNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=JQnyHsScwMfI/pruel2+3aOvx6O2WkjikPoFzTbPGGE=; fh=UMpI9xNuNgqQJ+4ORZzUAfqCIrqbus6+kd6pQTWoVi8=; b=E+MWJzSXUaHxI1V+QpE1y1y+1eswXs9HwZJeNq8XyAl7ef7TyoWB470tHPVdmGDWFs xH5ABmlgGG/XZWQIUWibq6M2lrSVvOLq2/TatalS7wSp2FiGZnv60tMepZF0RrqGodDt GGF1U1kBMQPpX4Ton4G6fNawd+t5IqsZwBIEZl1Ci1AEY2bS7HuBv0+iQ3pICqoLG8Ma DGfEWt2HVq3ErmPgGUTuIo5+lwFGNCfBY5pVJvNg1FgOANOM9i4v2vWXzrSPN/zkLA8c 0e8c4SJqtZPkYlAdRqBteuOiN5k/XelW0uCm75WKYwGarAzi8BPKNABSL44Ieufm+HTO AM4w==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777395292; x=1778000092; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JQnyHsScwMfI/pruel2+3aOvx6O2WkjikPoFzTbPGGE=; b=jXiBF1p/DTly5zriIeF1gvYv9omV3S1IOKxb9Nupsa8bFGWKo8Qo/9OwyLaw7YEf01 2vcDZ4xQFIDx6vIIigGvGrVXSyeD/6O9EjvigrEA+pQrAYvDTRWQPoq/I+rUXfQMJvEb 22OSiT/3502Bm1rTMx1XwCEMxbQqum3yFzeNTn8P+fHPbSJFRrCoSlSosKH68cbQGvOI j+6r1zMaduaVSpJHqfZWk+rgzVCsVE31cVgzbkGXqcSF+o/o4a2FcJ2/kWjb1fs1bVYN OTxJLskQcGRzobDXeroHOJHAYyUh8vQLC/QqKDyLemXreLdDbxdC/cPaanYIbOEqsGOX lKhQ== X-Forwarded-Encrypted: i=1; AFNElJ9Dg+Gqj29y8QaP2IJYkcocjQMohiYYo9V6qFN5oaGW6jGqR4lrnJfC3fVi71z4HxIxNw8Ma3PiNnkyLDSVnBJFINU1@freebsd.org X-Gm-Message-State: AOJu0YzqunjM0ePy//lMJwKas85UkbNARSAzv3/uBTsqOVdRGsJc2P5M 2g/hK4Or27XthOFr4RJa8ILzqqWOqcdJcYZ6cAe/X4ZzJ8EeYqKdr4Rn/Wx4WPs/odWZavp4dxU /OJFTfF0x7cs+lHDfC3qlbRRWtx6cOEM= X-Gm-Gg: AeBDieudhsiFraI2R7nEW9epbyKCCKyMAXOgJYGtpQKLg4wWZ08P3vqr6Meg42PUjWK Ng1HGz1DkRc0hsAhssRBbwTDMDDqX0PVOGoxtZ9ZX7FcDi8s/p4k7ILNA64G0vb7gUN8fVYBA03 Z9Q/lkAy78+Y1xxRAqU0IptrZSI1XtGpb/lW41BGYlVy9xchVDVfOB1DqWArLZNjFfPQqSVT5yF E+18S1NVpjDGw+lF8QsfC3eOiVS92gwLuO/0HPcPYNieSi/Fd1TnrfZpaYqa2r9qywzZZ2qSyPI XaF7PbJvTMKvtTNPRVSvGXsv5MhOGBWz7eNORGtSp+dbbaFPhFXnLwl0TBv5iHxvmgM+zhVDU8E x6G381UDbE2Qus7abH8fOltRXdByOSzoLYhxycW86I6LXS47vhBsRA2TAOYFz609d3H9f X-Received: by 2002:a05:6214:d89:b0:8ac:a6f7:8a6d with SMTP id 6a1803df08f44-8b3e38fa1f5mr49698696d6.13.1777395292561; Tue, 28 Apr 2026 09:54:52 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <69d12614.3d42a.5c3f48a2@gitrepo.freebsd.org> In-Reply-To: <69d12614.3d42a.5c3f48a2@gitrepo.freebsd.org> From: Adrian Chadd Date: Tue, 28 Apr 2026 09:54:40 -0700 X-Gm-Features: AVHnY4IOrscQmEEBKw1zSyvuOFs1Wpt6IHNyeX_pIxEUhnjgFq32tnNt5JmTFbM Message-ID: Subject: Re: git: 0b39d72d0491 - main - virtio: use modern mode for transitional device by default To: Michael Tuexen Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, =?UTF-8?B?VGltbyBWw7Zsa2Vy?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Result: default: False [-1.80 / 15.00]; ARC_ALLOW(-1.00)[google.com:s=arc-20240605:i=1]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_SPAM_MEDIUM(1.00)[0.999]; NEURAL_HAM_SHORT(-0.90)[-0.898]; FORGED_SENDER(0.30)[adrian@freebsd.org,adrianchadd@gmail.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_ONE(0.00)[1]; FREEMAIL_ENVFROM(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; MISSING_XM_UA(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[adrian@freebsd.org,adrianchadd@gmail.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.219.41:from]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; TAGGED_FROM(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[209.85.219.41:from]; RCVD_TLS_LAST(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; R_DKIM_NA(0.00)[] X-Rspamd-Queue-Id: 4g4mkj5J7Jz3YDL X-Spamd-Bar: - hi! FWIW, this has broken virtio on qemu ppc64 pseries VMs: ``` vtnet0: numa-domain 0 on virtio_pci0 virtio_pci0: virtqueue 1 (vtnet0-tx0) does not exist (size is zero) virtio_pci0: cannot allocate virtqueue 1: 19 vtnet0: cannot allocate virtqueues device_attach: vtnet0 attach returned 19 virtio_pci1: port 0x100-0x17f mem 0x81040000-0x81040fff,0x210000010000-0x210000013fff irq 4611 at device 3.0 numa-domain 0 on pci0 vtblk0: numa-domain 0 on virtio_pci1 qemu-system-ppc64: wrong value for queue_enable 100 ``` Is there any way to detect that we're running in an environment where the new way won't work? The snippet in my qemu setup is: ``` -drive file=3Dppc64be-1.qcow2,format=3Dqcow2,id=3Dhd0,if=3Dnone \ -device virtio-blk-pci,drive=3Dhd0 \ -drive file=3Dppc64be-data.qcow2,format=3Dqcow2,id=3Dhd1,if=3Dnone = \ -device virtio-blk-pci,drive=3Dhd1 \ -netdev tap,id=3Dnd0,ifname=3Dtap1 -device virtio-net,netdev=3Dnd0,mac=3D00:08:01:13:00:01 ``` -adrian On Sat, 4 Apr 2026 at 07:54, Michael Tuexen wrote: > > The branch main has been updated by tuexen: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D0b39d72d0491c77e3e9883015b= 1fac46663c71de > > commit 0b39d72d0491c77e3e9883015b1fac46663c71de > Author: Timo V=C3=B6lker > AuthorDate: 2026-04-04 14:49:54 +0000 > Commit: Michael Tuexen > CommitDate: 2026-04-04 14:49:54 +0000 > > virtio: use modern mode for transitional device by default > > This patch changes the default value of the loader tunable > hw.virtio.pci.transitional to 1. This means, virtio uses the > modern mode for transitional devices by default. > > The return values of vtpci_modern_probe() and vtpci_legacy_probei() > were chosen to prefer modern mode, but hw.virtio.pci.transitional=3D0 > prevents modern mode. > Setting hw.virtio.pci.transitional to 1 by default seems a better fit= . > > Reviewed by: tuexen > Differential Revision: https://reviews.freebsd.org/D55894 > --- > share/man/man4/virtio.4 | 2 +- > sys/dev/virtio/pci/virtio_pci_modern.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/share/man/man4/virtio.4 b/share/man/man4/virtio.4 > index 8252cc1b7954..6af6300b1cee 100644 > --- a/share/man/man4/virtio.4 > +++ b/share/man/man4/virtio.4 > @@ -114,7 +114,7 @@ use the legacy > .Nm > driver > .Pq 0 . > -The default value is 0. > +The default value is 1. > .El > .Sh SEE ALSO > .Xr virtio_balloon 4 , > diff --git a/sys/dev/virtio/pci/virtio_pci_modern.c b/sys/dev/virtio/pci/= virtio_pci_modern.c > index 108fd2b5f8e9..baf7c448bb95 100644 > --- a/sys/dev/virtio/pci/virtio_pci_modern.c > +++ b/sys/dev/virtio/pci/virtio_pci_modern.c > @@ -191,7 +191,7 @@ static void vtpci_modern_write_device_8(struct vtpci_= modern_softc *, > /* Tunables. */ > SYSCTL_DECL(_hw_virtio_pci); > > -static int vtpci_modern_transitional =3D 0; > +static int vtpci_modern_transitional =3D 1; > SYSCTL_INT(_hw_virtio_pci, OID_AUTO, transitional, CTLFLAG_RDTUN, > &vtpci_modern_transitional, 0, > "If 0, a transitional VirtIO device is used in legacy mode; otherwis= e, in modern mode."); >