From owner-svn-src-head@FreeBSD.ORG Tue Nov 22 21:53:04 2011 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E52501065674; Tue, 22 Nov 2011 21:53:04 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 93F468FC19; Tue, 22 Nov 2011 21:53:03 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id XAA24726; Tue, 22 Nov 2011 23:53:02 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1RSyGz-0003an-RF; Tue, 22 Nov 2011 23:53:01 +0200 Message-ID: <4ECC19BD.20401@FreeBSD.org> Date: Tue, 22 Nov 2011 23:53:01 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:8.0) Gecko/20111108 Thunderbird/8.0 MIME-Version: 1.0 To: Marius Strobl References: <201111222128.pAMLSKqa010571@svn.freebsd.org> In-Reply-To: <201111222128.pAMLSKqa010571@svn.freebsd.org> X-Enigmail-Version: undefined Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r227843 - in head/sys: amd64/amd64 arm/econa arm/mv arm/xscale/i80321 arm/xscale/i8134x arm/xscale/ixp425 dev/aac dev/acpi_support dev/acpica dev/amr dev/arcmsr dev/bce dev/bfe dev/bge ... X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Nov 2011 21:53:05 -0000 on 22/11/2011 23:28 Marius Strobl said the following: > Author: marius > Date: Tue Nov 22 21:28:20 2011 > New Revision: 227843 > URL: http://svn.freebsd.org/changeset/base/227843 > > Log: > - There's no need to overwrite the default device method with the default > one. Interestingly, these are actually the default for quite some time > (bus_generic_driver_added(9) since r52045 and bus_generic_print_child(9) > since r52045) but even recently added device drivers do this unnecessarily. Maybe because it is not immediately obvious which methods do have sensible defaults and which do not (and why). Thus, copy+paste. E.g. bus_add_child vs bus_print_child below. > Modified: head/sys/dev/acpi_support/acpi_wmi.c > ============================================================================== > --- head/sys/dev/acpi_support/acpi_wmi.c Tue Nov 22 21:22:06 2011 (r227842) > +++ head/sys/dev/acpi_support/acpi_wmi.c Tue Nov 22 21:28:20 2011 (r227843) > @@ -175,7 +175,6 @@ static device_method_t acpi_wmi_methods[ > > /* bus interface */ > DEVMETHOD(bus_add_child, bus_generic_add_child), > - DEVMETHOD(bus_print_child, bus_generic_print_child), > > /* acpi_wmi interface */ > DEVMETHOD(acpi_wmi_provides_guid_string, -- Andriy Gapon