From owner-freebsd-net@FreeBSD.ORG Sat Mar 13 12:52:08 2010 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 713B4106566B for ; Sat, 13 Mar 2010 12:52:08 +0000 (UTC) (envelope-from earl.lapus@gmail.com) Received: from mail-px0-f200.google.com (mail-px0-f200.google.com [209.85.216.200]) by mx1.freebsd.org (Postfix) with ESMTP id 498768FC19 for ; Sat, 13 Mar 2010 12:52:08 +0000 (UTC) Received: by pxi38 with SMTP id 38so65418pxi.27 for ; Sat, 13 Mar 2010 04:52:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type; bh=xy1znkOBqxD847zLVexP/T/5zfIjo7tKQoEnqsLM2Po=; b=pFM/J1/kZ37BR4ylM0F0oHbcvJY7tsYM6THSowIBNIvue803fqLcdSSHAAWDzoo9kP PGe6D0YFY8g3pz/dhVVYysNflAvLO7M7PKIReu6e8kW3MwWAykw75KkJLgd6/n8F0bqP u20MLi4H8THH1DMepMGahht7iLsCzx0k3OK6w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=sX23VbkUpfERMYUpFkuAMVM1S8avi49Yl/N4HOyJIZOnP0Cf8yH/2qeYTgBHkncHMY /pEUDlz3Rfs1EgjNZJXedX3V5S9NlHr1xNrc6DsGD5zjSKglz/zn8pGHOW4kET53Adcc qyKi5/uTgglHPztsEuc5bUKDBww9hOTB/SSOY= MIME-Version: 1.0 Received: by 10.114.138.17 with SMTP id l17mr3680483wad.159.1268483129627; Sat, 13 Mar 2010 04:25:29 -0800 (PST) Date: Sat, 13 Mar 2010 20:25:29 +0800 Message-ID: <604f76121003130425u62764f59wa88b398f15540b61@mail.gmail.com> From: Earl Lapus To: freebsd-net@freebsd.org Content-Type: multipart/mixed; boundary=00504502d91858555e0481adbec4 Subject: [ping6] freeaddrinfo() X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Mar 2010 12:52:08 -0000 --00504502d91858555e0481adbec4 Content-Type: text/plain; charset=ISO-8859-1 Hi, I was browsing through the ping6 code and I noticed that one particular call to getaddrinfo() didn't have a freeaddrinfo() pair. All calls to getaddrinfo() should have an equivalent freeaddrinfo(), right? Attached is a patch that "tries-to-resolve" this very small issue (applies cleanly on an 8.0p2 kernel source). Also, I'm not not 100% sure if that is the correct place to call freeaddrinfo() - I hope someone on the list would be kind enough to have look. Cheers! -- There are seven words in this sentence. --00504502d91858555e0481adbec4 Content-Type: text/x-patch; charset=US-ASCII; name="ping6.diff" Content-Disposition: attachment; filename="ping6.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g6qe7c3q0 ZGlmZiAtcnVOIC4uL3NyYy9zYmluL3Bpbmc2L3Bpbmc2LmMgLi4vc3JjLm1vZC9zYmluL3Bpbmc2 L3Bpbmc2LmMKLS0tIC4uL3NyYy9zYmluL3Bpbmc2L3Bpbmc2LmMJMjAwOS0xMC0yNSAwOToxMDoy OS4wMDAwMDAwMDAgKzA4MDAKKysrIC4uL3NyYy5tb2Qvc2Jpbi9waW5nNi9waW5nNi5jCTIwMTAt MDMtMTMgMTk6NDY6NDUuMDAwMDAwMDAwICswODAwCkBAIC02MzUsNiArNjM1LDggQEAKIAkgICAg cmVzLT5haV9wcm90b2NvbCkpIDwgMCkKIAkJZXJyKDEsICJzb2NrZXQiKTsKIAorCWZyZWVhZGRy aW5mbyhyZXMpOworCiAJLyogc2V0IHRoZSBzb3VyY2UgYWRkcmVzcyBpZiBzcGVjaWZpZWQuICov CiAJaWYgKChvcHRpb25zICYgRl9TUkNBRERSKSAmJgogCSAgICBiaW5kKHMsIChzdHJ1Y3Qgc29j a2FkZHIgKikmc3JjLCBzcmNsZW4pICE9IDApIHsK --00504502d91858555e0481adbec4--