From owner-freebsd-scsi Mon Sep 23 13:44: 4 2002 Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 01AB637B401; Mon, 23 Sep 2002 13:44:03 -0700 (PDT) Received: from panzer.kdm.org (panzer.kdm.org [216.160.178.169]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4453943E6A; Mon, 23 Sep 2002 13:44:02 -0700 (PDT) (envelope-from ken@panzer.kdm.org) Received: from panzer.kdm.org (localhost [127.0.0.1]) by panzer.kdm.org (8.12.5/8.12.5) with ESMTP id g8NKi1KD038364; Mon, 23 Sep 2002 14:44:01 -0600 (MDT) (envelope-from ken@panzer.kdm.org) Received: (from ken@localhost) by panzer.kdm.org (8.12.5/8.12.5/Submit) id g8NKi1Tw038363; Mon, 23 Sep 2002 14:44:01 -0600 (MDT) (envelope-from ken) Date: Mon, 23 Sep 2002 14:44:01 -0600 From: "Kenneth D. Merry" To: Brooks Davis Cc: Matt Jacob , scsi@FreeBSD.ORG Subject: Re: cvs commit: src/sys/cam/scsi scsi_all.c Message-ID: <20020923144400.A38337@panzer.kdm.org> References: <200209230456.g8N4uZSW013370@freefall.freebsd.org> <20020923132415.A24262@Odin.AC.HMC.Edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <20020923132415.A24262@Odin.AC.HMC.Edu>; from brooks@one-eyed-alien.net on Mon, Sep 23, 2002 at 01:24:15PM -0700 Sender: owner-freebsd-scsi@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On Mon, Sep 23, 2002 at 13:24:15 -0700, Brooks Davis wrote: > On Sun, Sep 22, 2002 at 09:56:35PM -0700, Matt Jacob wrote: > > mjacob 2002/09/22 21:56:35 PDT > > > > Modified files: > > sys/cam/scsi scsi_all.c > > Log: > > A SCSI_DELAY of zero is a legitimate value to have. > > The notion that you must "always" have a delay is at best misinformed. > > This change only half fixed the check since there a boot/runtime check > at the bottom of the file in sec_scsi_delay. > > If we're going to allow 0 we should probably also allow values between > 0 and 100 as well and just toss the checks. I don't really object to > letting the user take aim at their foot if that's what they want to do. A SCSI_DELAY setting of 0 was legal before your commit, it just meant "set this to the minimum value". So, this just ends up making the semantics the same as before. Ken -- Kenneth Merry ken@kdm.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-scsi" in the body of the message