From owner-freebsd-current@FreeBSD.ORG Sat Nov 26 12:43:37 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9674316A41F for ; Sat, 26 Nov 2005 12:43:37 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id E6C4043D60 for ; Sat, 26 Nov 2005 12:43:36 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from fledge.watson.org (fledge.watson.org [209.31.154.41]) by cyrus.watson.org (Postfix) with ESMTP id 3A72E46B91; Sat, 26 Nov 2005 07:43:36 -0500 (EST) Date: Sat, 26 Nov 2005 12:43:36 +0000 (GMT) From: Robert Watson X-X-Sender: robert@fledge.watson.org To: Csaba Henk In-Reply-To: <20051126054748.GM2911@beastie.creo.hu> Message-ID: <20051126124248.L81764@fledge.watson.org> References: <20051125214738.GL2911@beastie.creo.hu> <20051126025620.GA62284@xor.obsecurity.org> <20051126054748.GM2911@beastie.creo.hu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: freebsd-current@freebsd.org, Kris Kennaway Subject: Re: double close strikes panic if md attaching a corrupt file X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 26 Nov 2005 12:43:37 -0000 On Sat, 26 Nov 2005, Csaba Henk wrote: > On Fri, Nov 25, 2005 at 09:56:20PM -0500, Kris Kennaway wrote: >>> I attach two patches, they realize the above ideas, respectively. >>> Note that I didn't test either. >> >> You probably should do so ;-) This isn't the easiest thing for someone >> to test without such corrupted media. > > Umm... I was hoping that someone in the list will suggest a way for > easily creating corrupt files. As I don't have a corrupt media, either > :) > > I picked this when Fuse was panicking upon md attaching from a Fuse > based filesystem, cf. > > http://lists.freebsd.org/pipermail/freebsd-ports/2005-November/027724.html Well, a very easy way to test would be to add a local modification to UFS to create a file flag that causes VOP_READ to return EIO :-). That way you can easily mark files to return EIO. Robert N M Watson