From nobody Tue May 6 21:20:32 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZsWX327cmz5vS90; Tue, 06 May 2025 21:20:35 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZsWX31gKnz3qCg; Tue, 06 May 2025 21:20:35 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746566435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1LjZVWwbtzv/zS8Ci6TkVHqkF1Jl4umR5AX2v/2rako=; b=v7xfqLVxVyfWbebpQm9sON50oc39khLSb8SYJbXWQGkpgUzQygwlwzmAR5dUToJH2Ugm6r BtwuMLpTkOvsxZ+vz+C96nbsG9T9dG93aEDUoL3vgohxZSam8DKIq3tye3aogIpCeDSoIA AQhlSoFy1akwkLlg7w55NFDG1puSi3ICESSnrR+Lhbg8dKhBhFXWb/gt8CBvmuxMUGaDwg HMBNAr3VJsrP7B7SUT9JdlW5u1s4ln7hHGwIR/2xRMPPzM0RGWUXI1Hyx+hsRBtEtm8OJL 7MeyH7zD+PXs2RWkK8253RdtxBZ+0lZPfyJjKR4jYNxS1TUfTtb9CTgh6ZUvDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1746566435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1LjZVWwbtzv/zS8Ci6TkVHqkF1Jl4umR5AX2v/2rako=; b=P7/zn8+nCg6omJHT07vWY2j28Zy9ncsBegC0J20xqmQnGn2w3aHsgY2tcp2QtkqGGqI+QN YvCsYgIaV+hECdcf0EiT3Id10d9FsbN3rrBZffkPOlEkSAqBLKw3Jn6Y/4cyr0LTb7c8Pc tLDkb8RN+V839FTgs6Wzq/3svOoazVdk+aj4OXiezzEYkL+NZGtZzN+hDguzkJTzaS7lYi EvYUnZxgOriWQheqLXiOmmQcx1tU9hcoqHVzNvkkDW7sQYsdoZglRyZ5eRnUEEp3ZPGxj9 ctgdIh0fRVzu3GaehBhIGDMtXBtgsI/T0jX/81WDu4pfpmmPmuoO6gIS+Oxw8w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1746566435; a=rsa-sha256; cv=none; b=VyWKmNTQ1QLLpOUljrbpKqp0vUvqZHZe9Zu70etzWjAAmnE6NCwifGmwng9bks9iyNjosC zrDa6FjcX7t4E7zl0D0jvcpZvmoAdMZ4Ga6pw/BkWK9allgAaKu8zbhbibyM/41XCFZFJ7 wG00qSlK0RyHktB1D7AQStc53zY4NWwxH3n87x9DJSNRJX5zf9tYMXyXLne74Qym5D7VJZ qEAp3MnF6SFZ2R5TzE8JRnFx5SPc1YtaoqXshsoZMc+aIZVjGqVi20IuQ562MePkgjZ1/G 4yf/LmZuAaDQVqglq6MTBM2tjEJu2tGpqiHvB5+dWCQVWdKXVw0Y/6ugOTr33Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4ZsWX23wGCz10WP; Tue, 06 May 2025 21:20:34 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Tue, 6 May 2025 14:20:32 -0700 From: Gleb Smirnoff To: Cy Schubert Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: d15792780760 - main - unix: new implementation of unix/stream & unix/seqpacket Message-ID: References: <202505051956.545JuOPR085707@gitrepo.freebsd.org> <20250506150654.DEAF8300@slippy.cwsent.com> <20250506154446.917B818D@slippy.cwsent.com> <20250506172901.E5DA4305@slippy.cwsent.com> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="llvy8OFwqUtJAMbb" Content-Disposition: inline In-Reply-To: <20250506172901.E5DA4305@slippy.cwsent.com> --llvy8OFwqUtJAMbb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, May 06, 2025 at 10:29:01AM -0700, Cy Schubert wrote: C> In the case of /usr/obj I did, C> C> rsync -aHv --delete --progress /usr/obj/. other_server:/usr/obj/. I think I was able to reproduce, but not sure. Can you please try the attached patch at your setup? -- Gleb Smirnoff --llvy8OFwqUtJAMbb Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename=uipc_sopoll.diff diff --git a/sys/kern/uipc_usrreq.c b/sys/kern/uipc_usrreq.c index 1722a43a800e..0836652b6a24 100644 --- a/sys/kern/uipc_usrreq.c +++ b/sys/kern/uipc_usrreq.c @@ -1681,11 +1681,12 @@ uipc_sopoll_stream_or_seqpacket(struct socket *so, int events, (POLLOUT | POLLWRNORM); if (sb->sb_state & SBS_CANTRCVMORE) revents |= POLLHUP; - if (!(revents & (POLLOUT | POLLWRNORM))) + if (!(revents & (POLLOUT | POLLWRNORM))) { so2->so_rcv.uxst_flags |= UXST_PEER_SEL; + selrecord(td, &so->so_wrsel); + } SOCK_RECVBUF_UNLOCK(so2); - } - if (!(revents & (POLLOUT | POLLWRNORM))) + } else selrecord(td, &so->so_wrsel); } } --llvy8OFwqUtJAMbb--