From owner-freebsd-net@FreeBSD.ORG Sun Jan 23 19:24:13 2005 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1598A16A4CE for ; Sun, 23 Jan 2005 19:24:13 +0000 (GMT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id B7C3043D3F for ; Sun, 23 Jan 2005 19:24:12 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id j0NJOjJE030520; Sun, 23 Jan 2005 11:24:45 -0800 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id j0NJOiLh030519; Sun, 23 Jan 2005 11:24:44 -0800 Date: Sun, 23 Jan 2005 11:24:44 -0800 From: Brooks Davis To: Jeremie Le Hen Message-ID: <20050123192444.GA29225@odin.ac.hmc.edu> References: <41F1E99A.5070001@ntmk.ru> <20050122152546.GG36660@obiwan.tataz.chchile.org> <20050122203347.GB4466@odin.ac.hmc.edu> <20050123112219.GJ36660@obiwan.tataz.chchile.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0OAP2g/MAC+5xKAE" Content-Disposition: inline In-Reply-To: <20050123112219.GJ36660@obiwan.tataz.chchile.org> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu cc: freebsd-net@freebsd.org cc: Boris Kovalenko Subject: Re: [PATCH] 802.1p priority (fixed) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 23 Jan 2005 19:24:13 -0000 --0OAP2g/MAC+5xKAE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jan 23, 2005 at 12:22:19PM +0100, Jeremie Le Hen wrote: > > > Having the possibility to test and set the 802.1p or TOS values > > > separately would avoid making a "trust"/"override" subtlety and will > > > obviously make it more flexible. > >=20 > > I agree on this point. The one thing to be careful of is that 802.1p > > priorities and TOS values work rather differently in that TOS values fit > > in to an existing field of the packet and 802.1p values require > > modifications to the header and adding data between the header and the > > real body, possiably with a resuling reduction in MTU (though what > > you're doing trying to use 802.1p priority with crappy nic I don't know > > :-). >=20 > I do not understand your point here. TOS is indeed an existing field > of the IPv4 header but AFAIK, this is the same for the 802.1p header [1]. > There are already 3 bits reserved for priority (802.1p) near the 802.1q > field which are both inside what they call "Tag Control Information". At the point you are examining layer 3 state, you either have already stripped off the ethernet header or have not created it yet so you can't just modify it. At least according to what I've read, you may or may not want to tag all traffic so if you strip the tags, you not want to use a vlan tag on the packet. You do have the actual storage the TOS values will use since you have the IP header. I'm basicly saying that they aren't necessicairly as similar as you might think. It might make sense to modify the TOS bits directly in the firewall, but it is simply not possiable to modify the 802.1p bits at that point because there's no where to put them. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --0OAP2g/MAC+5xKAE Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFB8/n7XY6L6fI4GtQRAkfkAJ0eJwF02IKcm+Rg+dIoObSTjAeREACfQ/jl ySG7PtfBoVo4wjEjD6ZdWkM= =kvSM -----END PGP SIGNATURE----- --0OAP2g/MAC+5xKAE--