From owner-freebsd-bugs@FreeBSD.ORG  Wed Feb  1 23:00:35 2006
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4E12416A420
	for <freebsd-bugs@hub.freebsd.org>;
	Wed,  1 Feb 2006 23:00:35 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DD21F43D70
	for <freebsd-bugs@hub.freebsd.org>;
	Wed,  1 Feb 2006 23:00:30 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k11N0U1x026634
	for <freebsd-bugs@freefall.freebsd.org>; Wed, 1 Feb 2006 23:00:30 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k11N0UpA026633;
	Wed, 1 Feb 2006 23:00:30 GMT (envelope-from gnats)
Date: Wed, 1 Feb 2006 23:00:30 GMT
Message-Id: <200602012300.k11N0UpA026633@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Jilles Tjoelker <jilles@stack.nl>
Cc: 
Subject: Re: bin/89410: [PATCH] sh(1) missing \u interpolation and bug/fix
	in \W
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Jilles Tjoelker <jilles@stack.nl>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 01 Feb 2006 23:00:35 -0000

The following reply was made to PR bin/89410; it has been noted by GNATS.

From: Jilles Tjoelker <jilles@stack.nl>
To: bug-followup@FreeBSD.org, bsd@rubyforge.org
Cc:  
Subject: Re: bin/89410: [PATCH] sh(1) missing \u interpolation and bug/fix in \W
Date: Wed, 1 Feb 2006 23:58:10 +0100

 Some comments about the patch:
 - You should not call getpwuid() for every prompt, perhaps use $USER
   instead for the \u expansion
 - \w/\W should use more something like $PWD (leave the symlinks) and
   just compare with $HOME (bash3 does the same). This needs wider
   changes over the code though.
 - The code in HEAD seems to have some other bugfixes since you patched
   it.
 - Your dot.shrc patch looks way too redhatty :P
 
 -- 
 Jilles Tjoelker