From owner-freebsd-arch@FreeBSD.ORG Thu Dec 25 14:38:14 2014 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4C2607E3; Thu, 25 Dec 2014 14:38:14 +0000 (UTC) Received: from elvis.mu.org (elvis.mu.org [IPv6:2001:470:1f05:b76::196]) by mx1.freebsd.org (Postfix) with ESMTP id 3171764C3E; Thu, 25 Dec 2014 14:38:14 +0000 (UTC) Received: from [10.0.1.106] (c-76-21-10-192.hsd1.ca.comcast.net [76.21.10.192]) by elvis.mu.org (Postfix) with ESMTPSA id C2578341F85F; Thu, 25 Dec 2014 06:38:13 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: Libxo bugs and fixes. From: Alfred Perlstein X-Mailer: iPhone Mail (12B440) In-Reply-To: <29784.1419492726@chaos> Date: Thu, 25 Dec 2014 06:38:12 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <26E73A9E-6EA4-4698-885D-BD91906D32D2@mu.org> References: <201408141640.s7EGe422096656@idle.juniper.net> <53ED57F2.5020808@mu.org> <20140815053604.9E40B580A2@chaos.jnpr.net> <53EDB0EF.6090902@mu.org> <20140815173830.93832580A2@chaos.jnpr.net> <53EEA74B.9070107@mu.org> <20140816045254.5F47E580A2@chaos.jnpr.net> <549BA675.9070107@freebsd.org> <29784.1419492726@chaos> To: "Simon J. Gerraty" Cc: Marcel Moolenaar , Phil Shafer , John-Mark Gurney , Alfred Perlstein , "arch@freebsd.org" , Poul-Henning Kamp , freebsd-arch , Konstantin Belousov X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Dec 2014 14:38:14 -0000 > On Dec 24, 2014, at 11:32 PM, Simon J. Gerraty wrote: >=20 > Alfred Perlstein wrote: >> 1) We need libxo to support explicit fflush: >> https://reviews.freebsd.org/D1379 >=20 > This is probably sub-optimal. =20 > Supporting flushing isn't the same thing as blindly doing it. > Probably better if caller can indicate a need for flushing regularly. > Will try and catch up with Phil to discuss. Yes, the patch leaves it to the caller. The otherwise when you run "netstat -= -libxo json 1" you only see output every BUFSIZE bytes from netstat.=20 With the fix I added the xo_flush calls actually work. Which I think is what= you want as well.=20 >=20 >> 2) We need libxo to support time series data. I don't have a patch >> for that, but I would like to ask for ideas on this. This would be >> extremely helpful for instance "netstat 1". would like to get a very >> accurate timestamp with each row. Suggestions on how to do this >> correctly AND *consistently* via libxo would make sense. >>=20 >> 3) I have netstat mostly converted over, however not all the json is >> valid, I will be doing another pass ASAP on this. >> https://reviews.freebsd.org/D1380 >>=20 >> 4) Can I as politely as I know how, ask that Juniper keep the patches >> against the userland utils up to date either in a project branch in >> SVN, or simply in a fork of the github repo? This would make life so >> much easer to deal with. >=20 > I assume that commits would be more use? Yes! Also we should really have unit tests made to make sure the json is valid. I= 've found some bugs and I am fixing them, but it will take some time and I w= ant to avoid regressions.=20 > _______________________________________________ > freebsd-arch@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-arch > To unsubscribe, send any mail to "freebsd-arch-unsubscribe@freebsd.org" >=20