From owner-freebsd-emulation@FreeBSD.ORG  Wed Jan 31 15:17:04 2007
Return-Path: <owner-freebsd-emulation@FreeBSD.ORG>
X-Original-To: emulation@freebsd.org
Delivered-To: freebsd-emulation@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 5591516A401
	for <emulation@freebsd.org>; Wed, 31 Jan 2007 15:17:04 +0000 (UTC)
	(envelope-from xdivac02@stud.fit.vutbr.cz)
Received: from eva.fit.vutbr.cz (eva.fit.vutbr.cz [147.229.176.14])
	by mx1.freebsd.org (Postfix) with ESMTP id D09BE13C48E
	for <emulation@freebsd.org>; Wed, 31 Jan 2007 15:17:03 +0000 (UTC)
	(envelope-from xdivac02@stud.fit.vutbr.cz)
Received: from eva.fit.vutbr.cz (localhost [127.0.0.1])
	by eva.fit.vutbr.cz (envelope-from xdivac02@eva.fit.vutbr.cz)
	(8.13.8/8.13.7) with ESMTP id l0VFH1nv094718
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Wed, 31 Jan 2007 16:17:01 +0100 (CET)
Received: (from xdivac02@localhost)
	by eva.fit.vutbr.cz (8.13.8/8.13.3/Submit) id l0VFH0fJ094717;
	Wed, 31 Jan 2007 16:17:00 +0100 (CET)
Date: Wed, 31 Jan 2007 16:17:00 +0100
From: Divacky Roman <xdivac02@stud.fit.vutbr.cz>
To: xdivac02@stud.fit.vutbrcz, emulation@freebsd.org
Message-ID: <20070131151700.GA94000@stud.fit.vutbr.cz>
References: <20070131123615.GA1895@mail.scottro.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20070131123615.GA1895@mail.scottro.net>
User-Agent: Mutt/1.4.2.2i
X-Scanned-By: MIMEDefang 2.57 on 147.229.176.14
Cc: 
Subject: Re: The patch for 2.6.16 emulation
X-BeenThere: freebsd-emulation@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Development of Emulators of other operating systems
	<freebsd-emulation.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-emulation>
List-Post: <mailto:freebsd-emulation@freebsd.org>
List-Help: <mailto:freebsd-emulation-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-emulation>, 
	<mailto:freebsd-emulation-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Jan 2007 15:17:04 -0000

On Wed, Jan 31, 2007 at 07:36:15AM -0500, Scott Robbins wrote:
> I tried the patch for linux_emul.c last night. 
> 
> However, it didn't seem to change anything.  Linux-opera still leaves a
> zombied process each time it's closed.   

updated patch:
--- /tmp/tmp.1529.0     Wed Jan 31 16:16:13 2007
+++ /root/projects/linuxolator/src/sys/compat/linux/linux_emul.c        Wed Jan 31 10:22:57 2007
@@ -165,6 +165,17 @@

        KASSERT(em != NULL, ("proc_exit: emuldata not found.\n"));

+       /* reparent all non thread leaders to initproc */
+       if (em->shared->group_pid != p->p_pid) {
+               sx_xlock(&proctree_lock);
+               wakeup(initproc);
+               PROC_LOCK(p);
+               proc_reparent(p, initproc);
+               p->p_sigparent = SIGCHLD;
+               PROC_UNLOCK(p);
+               sx_xunlock(&proctree_lock);
+       }
+
        child_clear_tid = em->child_clear_tid;

        EMUL_UNLOCK(&emul_lock);

with this I dont have any zombie processes and world looks brighter ;)