From owner-cvs-src@FreeBSD.ORG  Thu Jul 15 21:28:36 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id D28CF16A4CE; Thu, 15 Jul 2004 21:28:36 +0000 (GMT)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id C3B1A43D2D; Thu, 15 Jul 2004 21:28:36 +0000 (GMT)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id BA06E5C8DE; Thu, 15 Jul 2004 14:28:36 -0700 (PDT)
Date: Thu, 15 Jul 2004 14:28:36 -0700
From: Alfred Perlstein <alfred@freebsd.org>
To: John Baldwin <jhb@FreeBSD.org>
Message-ID: <20040715212836.GT95729@elvis.mu.org>
References: <20040715050225.GA87532@freefall.freebsd.org>
	<20040715052941.GL95729@elvis.mu.org> <200407151415.03555.jhb@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200407151415.03555.jhb@FreeBSD.org>
User-Agent: Mutt/1.4.2.1i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: Bosko Milekic <bmilekic@FreeBSD.org>
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern kern_shutdown.c vfs_subr.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Jul 2004 21:28:37 -0000

* John Baldwin <jhb@FreeBSD.org> [040715 11:56] wrote:
> On Thursday 15 July 2004 01:29 am, Alfred Perlstein wrote:
> > >   Also, why do you copy the proc name to the stack lower in
> > >   kern_shutdown.c?  Do you fear that the proc might change from
> > >   under you when you're at the bottom and you can't therefore
> > >   only keep a reference to the proc instead?
> >
> > Because I don't know if the proc will be there after it nukes itself.
> 
> They don't nuke themselves, they just go to sleep.  A quick look at the code 
> would have revealed this.

y'know what, in the context of fixing a printf I wasn't really
interested in looking that far into the scheduler.  A 20 char stack
variable and a string copy at shutdown isn't such a big deal.  If it
bugs you guys that much, why don't you just fix it?

Or are you worried about getting 15 emails about how you inefficiently
printing a non-critical string like I have? :)

hugs,
-- 
- Alfred Perlstein
- Research Engineering Development Inc.
- email: bright@mu.org cell: 408-480-4684