From owner-freebsd-current@FreeBSD.ORG Wed Dec 10 23:54:23 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 14FE71065676; Wed, 10 Dec 2008 23:54:23 +0000 (UTC) (envelope-from onemda@gmail.com) Received: from yx-out-2324.google.com (yx-out-2324.google.com [74.125.44.28]) by mx1.freebsd.org (Postfix) with ESMTP id 9234D8FC1B; Wed, 10 Dec 2008 23:54:22 +0000 (UTC) (envelope-from onemda@gmail.com) Received: by yx-out-2324.google.com with SMTP id 8so349615yxb.13 for ; Wed, 10 Dec 2008 15:54:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=LFC8NgYZByxJkMUd/TIK2615ymZFBdnhWt1lbEPo268=; b=ISwIv59683BsQpd91/P+TcmQ/Kdzew+tCuSV0PAOZkm2yk7XQ8ns5/+1VhD59nFHmc Ri2OzvFVfQ09I+qCIFNaFFzm4th77mCAepTCsXti13Q0b/uoBebQ0TKD3Mt0hj7t8Ifz a6z9i/8imoElNXFHLOJlXgExsTAWYNvbqN7S0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=pWw+oFZLbp9p2bwZp0mDuy8Vdm/nPQNn6QiYhPmrXqX7GD8nKVBm5+rE1YYUTkFav5 owz729DgzfakBy9pnYMwQz2Nk7ZdIa1m67HZmD8e/S1GMDL/2jY+9M8nnq4+GY8KcLOn sN/q2/5T+1d6gxMhX4hLaO6dReChO9uDE1dUY= Received: by 10.231.16.75 with SMTP id n11mr26519iba.40.1228953260996; Wed, 10 Dec 2008 15:54:20 -0800 (PST) Received: by 10.231.12.5 with HTTP; Wed, 10 Dec 2008 15:54:20 -0800 (PST) Message-ID: <3a142e750812101554o656347f9w42c7486db4fc4a9e@mail.gmail.com> Date: Thu, 11 Dec 2008 00:54:20 +0100 From: "Paul B. Mahol" To: "John Baldwin" In-Reply-To: <200812101450.04638.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200811191510.53793.jhb@FreeBSD.org> <200812091602.10850.jhb@freebsd.org> <3a142e750812100922m553be9c6sdcd81d98c81c7ab4@mail.gmail.com> <200812101450.04638.jhb@freebsd.org> Cc: freebsd-current@freebsd.org Subject: Re: [PATCH] MPSAFE/LOOKUP_SHARED cd9660 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Dec 2008 23:54:23 -0000 On 12/10/08, John Baldwin wrote: > On Wednesday 10 December 2008 12:22:43 pm Paul B. Mahol wrote: >> On 12/9/08, John Baldwin wrote: >> > The RRIP stuff is all done in cd9660_vget_internal() under an exclusive >> > lock. >> > It could be a property of the ISO image. "PX" holds permissions (owner, >> > etc.). Do you get the same messages w/o the patch with the same ISO > image / >> > CD? >> > >> > -- >> > John Baldwin >> > >> >> I searched little for this message and found kern/63446 PR interesting > comment: >> >> Caused by cd9660_vnops.c rev. 1.77. VOP_READDIR returns bogus >> d_fileno, VFS_VGET on this value returns bogus vnode with zeroed > attributes. >> >> I think that whatever locking is done is done wrong. > > That issue isn't a locking issue, it's an issue with VOP_READDIR() using a > different meaning for i-node numbers than VFS_VGET(), and would happen > regardless of any Giant or vnode locking. Yes, I know that that issue/PR doesnt have anything to do with locking. But displaying bogus messages and still having functional cd9660 for general use means that something is not correctly locked. -- Paul