From owner-freebsd-bugs Thu Jan 10 12:48:10 2002 Delivered-To: freebsd-bugs@freebsd.org Received: from mail5.speakeasy.net (mail5.speakeasy.net [216.254.0.205]) by hub.freebsd.org (Postfix) with ESMTP id 1F4B537B416 for ; Thu, 10 Jan 2002 12:48:06 -0800 (PST) Received: (qmail 13096 invoked from network); 10 Jan 2002 20:48:04 -0000 Received: from unknown (HELO laptop.baldwin.cx) ([64.81.54.73]) (envelope-sender ) by mail5.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 10 Jan 2002 20:48:04 -0000 Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <54540.62.179.128.205.1010684965.squirrel@webmail.debolaz.com> Date: Thu, 10 Jan 2002 12:47:25 -0800 (PST) From: John Baldwin To: Anders Nor Berle Subject: Re: kern/33124: kthread_create doesnt mark kthreads as kthreads. Cc: freebsd-bugs@FreeBSD.org, sheldonh@FreeBSD.org Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On 10-Jan-02 Anders Nor Berle wrote: >> >> This is actually kind of bogus. Nobody uses this flag except aio, and aio >> just sets >> the flag, no code actually checks it. P_KTHREAD is a new flag in -current >> used in a >> few places. Unless the submitter has code that actually checks P_KTHREADP >> and needs >> it set for some reason, I would rather see the flag killed. One thing that >> might be >> nice to MFC is changing aio to use kthread_create rather than using its own >> home-rolled version. >> > Well, I do have some code, related to jail, which checks for P_KTHREADP, but > if P_KTHREAD > becomes available instead, that'll do of course. I was just following what > was already > there. :) Hmm, how about this: kill P_KTHREADP, instead MFC fixes to aio to use the kthread API and then MFC the P_KTHREAD flag. How does that sound? Well, for backwards compatibility, it might be better to #define P_KTHREADP P_KTHREAD after you MFC P_KTHREAD rather than killing the flag. > - Anders Nor Berle -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message