Date: Tue, 18 Oct 2005 10:33:14 +0100 From: Ceri Davies <ceri@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/87607: devel/subversion: Correct minor issues with Makefile Message-ID: <E1ERnqM-00077e-LX@shrike.submonkey.net> Resent-Message-ID: <200510180933.j9I9Xuc9026297@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 87607
>Category: ports
>Synopsis: devel/subversion: Correct minor issues with Makefile
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: doc-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Oct 18 09:33:56 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator: Ceri Davies
>Release: FreeBSD 6.0-RC1 i386
>Organization:
Submonkey
>Environment:
System: FreeBSD shrike.private.submonkey.net 6.0-RC1 FreeBSD 6.0-RC1 #3: Sat Oct 15 14:01:52 BST 2005 root@shrike.private.submonkey.net:/usr/obj/usr/src/sys/SHRIKE i386
>Description:
The devel/subversion port tells you at build time that it will
create the repository for you, but only if you have asked it not
to.
There are also some minor typos in the Makefile.
>How-To-Repeat:
Install the devel/subversion port without defining
WITH_REPOSITORY_CREATION. Panic slightly as it tells you that
it wil create a repository for you.
>Fix:
Index: subversion/Makefile
===================================================================
RCS file: /usr/home/ncvs/ports/devel/subversion/Makefile,v
retrieving revision 1.84
diff -u -r1.84 Makefile
--- subversion/Makefile 16 Sep 2005 12:07:29 -0000 1.84
+++ subversion/Makefile 18 Oct 2005 09:29:59 -0000
@@ -248,7 +248,7 @@
@${ECHO_MSG} "Build with Java (JavaHL) bindings."
.else
@${ECHO_MSG} "You can enable Java bindings by defining WITH_JAVA."
- @${ECHO_MSG} "You should have apr builded with threads for Java support!"
+ @${ECHO_MSG} "You should have apr built with threads for Java support!"
.endif
@${ECHO_MSG} ""
.if defined(WITH_MOD_DAV_SVN)
@@ -278,6 +278,10 @@
.if defined(WITH_REPOSITORY_CREATION)
@${ECHO_MSG} "I will create (or use, if it exists) \"${SVNGROUP}\" group."
@${ECHO_MSG} "Make sure that all committers are its members."
+ @${ECHO_MSG} ""
+ @${ECHO_MSG} "Repository will be created at '${SVNREPOS}' with group '${SVNGROUP}'."
+ @${ECHO_MSG} "Type of repository will be '${SVNFSTYPE}'."
+ @${ECHO_MSG} "You could change these settings by defining SVNREPOS, SVNGROUP and SVNFSTYPE."
.else
@${ECHO_MSG} "You can have the repository created for you by defining"
@${ECHO_MSG} "WITH_REPOSITORY_CREATION."
@@ -287,11 +291,6 @@
@${ECHO_MSG} "* this group is the group id of the db/ and locks/"
@${ECHO_MSG} " subdirectories of your repository"
@${ECHO_MSG} "* the above subdirectories are writable by this group"
- @${ECHO_MSG} ""
- @${ECHO_MSG} "Repository will be created at '${SVNREPOS}' with group '${SVNGROUP}'."
- @${ECHO_MSG} "Type of repository will be '${SVNFSTYPE}'."
- @${ECHO_MSG} "You could change these settings by defining SVNREPOS, SVNGROUP and SVNFSTYPE"
- @${ECHO_MSG} ""
.endif
@${ECHO_MSG} ""
.if !defined(NOPORTDOCS) && defined(WITH_BOOK)
@@ -330,7 +329,7 @@
${ECHO_MSG} 'You should build `'"${APR_PORT}' with db4 support to use subversion with it." ; \
${ECHO_MSG} 'Please rebuild `'"${APR_PORT}' with option "'`'"${OPT_NAME}' and try again." ; \
${ECHO_MSG} "" ; \
- ${ECHO_MSG} "Or you can disable db4 support. Only 'fs' repository backend will be availible." ; \
+ ${ECHO_MSG} "Or you can disable db4 support. Only 'fs' repository backend will be available." ; \
${ECHO_MSG} "To disable db4 support, define WITHOUT_BDB." ; \
${ECHO_MSG} "" ; \
${FALSE} ; \
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E1ERnqM-00077e-LX>