From owner-svn-src-head@FreeBSD.ORG Thu Jan 8 17:51:16 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 24F331065688; Thu, 8 Jan 2009 17:51:16 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 13CAE8FC18; Thu, 8 Jan 2009 17:51:16 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n08HpFLb028867; Thu, 8 Jan 2009 17:51:15 GMT (envelope-from mav@svn.freebsd.org) Received: (from mav@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n08HpFV3028866; Thu, 8 Jan 2009 17:51:15 GMT (envelope-from mav@svn.freebsd.org) Message-Id: <200901081751.n08HpFV3028866@svn.freebsd.org> From: Alexander Motin Date: Thu, 8 Jan 2009 17:51:15 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r186907 - head/sys/netgraph X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jan 2009 17:51:17 -0000 Author: mav Date: Thu Jan 8 17:51:15 2009 New Revision: 186907 URL: http://svn.freebsd.org/changeset/base/186907 Log: Mark ng_vjc node as FORCE_WRITER to protect slcompress state. I think it can be the reason of livelock in netgraph reported by some mpd users. MFC after: 3 days Modified: head/sys/netgraph/ng_vjc.c Modified: head/sys/netgraph/ng_vjc.c ============================================================================== --- head/sys/netgraph/ng_vjc.c Thu Jan 8 17:47:45 2009 (r186906) +++ head/sys/netgraph/ng_vjc.c Thu Jan 8 17:51:15 2009 (r186907) @@ -249,6 +249,9 @@ ng_vjc_constructor(node_p node) NG_NODE_SET_PRIVATE(node, priv); + /* slcompress is not thread-safe. Protect it's state here. */ + NG_NODE_FORCE_WRITER(node); + /* Done */ return (0); }