From owner-p4-projects@FreeBSD.ORG  Sat May  5 20:05:38 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 4788316A501; Sat,  5 May 2007 20:05:38 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id E819F16A403
	for <perforce@freebsd.org>; Sat,  5 May 2007 20:05:37 +0000 (UTC)
	(envelope-from mjacob@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.freebsd.org (Postfix) with ESMTP id D95B713C45D
	for <perforce@freebsd.org>; Sat,  5 May 2007 20:05:37 +0000 (UTC)
	(envelope-from mjacob@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l45K5bFR081330
	for <perforce@freebsd.org>; Sat, 5 May 2007 20:05:37 GMT
	(envelope-from mjacob@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l45K5bK1081326
	for perforce@freebsd.org; Sat, 5 May 2007 20:05:37 GMT
	(envelope-from mjacob@freebsd.org)
Date: Sat, 5 May 2007 20:05:37 GMT
Message-Id: <200705052005.l45K5bK1081326@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	mjacob@freebsd.org using -f
From: Matt Jacob <mjacob@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 119299 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 05 May 2007 20:05:38 -0000

http://perforce.freebsd.org/chv.cgi?CH=119299

Change 119299 by mjacob@mjexp on 2007/05/05 20:05:20

	misplaced isp_free_pcmd led to a panic at double free.

Affected files ...

.. //depot/projects/mjexp/sys/dev/isp/isp_freebsd.c#24 edit

Differences ...

==== //depot/projects/mjexp/sys/dev/isp/isp_freebsd.c#24 (text+ko) ====

@@ -2478,7 +2478,6 @@
 			    isp_watchdog, ccb);
 			break;
 		case CMD_RQLATER:
-			isp_free_pcmd(isp, ccb);
 			/*
 			 * Handle initial and subsequent loop down cases
 			 */
@@ -2495,6 +2494,7 @@
 				ccb->ccb_h.status =
 				    CAM_SEL_TIMEOUT|CAM_DEV_QFRZN;
 				xpt_freeze_devq(ccb->ccb_h.path, 1);
+				isp_free_pcmd(isp, ccb);
 				xpt_done(ccb);
 				break;
 			}