Date: Mon, 30 Sep 2019 19:25:01 +0000 From: bugzilla-noreply@freebsd.org To: toolchain@FreeBSD.org Subject: [Bug 240928] clang segfault when compiling with -march=bonnel (CPUTYPE=atom in make.conf) Message-ID: <bug-240928-29464-781wJsWSQM@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-240928-29464@https.bugs.freebsd.org/bugzilla/> References: <bug-240928-29464@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240928 --- Comment #2 from commit-hook@freebsd.org --- A commit references this bug: Author: dim Date: Mon Sep 30 19:24:21 UTC 2019 New revision: 352915 URL: https://svnweb.freebsd.org/changeset/base/352915 Log: Pull in r357528 from upstream llvm trunk (by Craig Topper): [X86] Check MI.isConvertibleTo3Addr() before calling convertToThreeAddress in X86FixupLEAs. X86FixupLEAs just assumes convertToThreeAddress will return nullptr for any instruction that isn't convertible. But the code in convertToThreeAddress for X86 assumes that any instruction coming in has at least 2 operands and that the second one is a register. But those properties aren't guaranteed of all instructions. We should check the instruction property first. Pull in r365720 from upstream llvm trunk (by Craig Topper): [X86] Don't convert 8 or 16 bit ADDs to LEAs on Atom in FixupLEAPass. We use the functions that convert to three address to do the conversion, but changing an 8 or 16 bit will cause it to create a virtual register. This can't be done after register allocation where this pass runs. I've switched the pass completely to a white list of instructions that can be converted to LEA instead of a blacklist that was incorrect. This will avoid surprises if we enhance the three address conversion function to include additional instructions in the future. Fixes PR42565. This should fix assertions/segfaults when compiling certain ports with CPUTYPE=3Datom. PR: 240928 MFC after: 3 days Changes: head/contrib/llvm/lib/Target/X86/X86FixupLEAs.cpp --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-240928-29464-781wJsWSQM>