From owner-svn-src-head@freebsd.org Wed Jan 18 18:14:08 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B919ECB6CE0; Wed, 18 Jan 2017 18:14:08 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6FEAC11D3; Wed, 18 Jan 2017 18:14:08 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-wm0-f53.google.com with SMTP id c85so255680008wmi.1; Wed, 18 Jan 2017 10:14:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc:content-transfer-encoding; bh=Lx0CFUzqvsRlgCJQ3MJ5zjceL5ucYw//KzjDFvoM8xI=; b=UHf6oA5jpkmC0Wr+LQz454W/tLs5B8iSNZm5aUtz4MKRQ5sKXGzl1SYjxO7tVoGQkn eRH7hDjsrULx13qDy97lVog9uJRf2iaLnpZYCjYwXQcx/o7ZTbiYFHLFFd6QAFIWlT0V /yoaZSKeS6sbS8uswp2ltvBPBb4G6IGm4l7t3NK9/smgcMBeyusDy1iVNGEuNLk3uUMw 5+QAWwFJL8eLzjL5qHZS/uplCipXEGlDnTJZ/i6zba4GNajThq1I/3tKR0NxfjbvEe7q Hi4ngZr4RTaeCaVTL+s5cNGjnmdTIYvc6Lm+EQDpJkvBeI+KmpHgo74S0Vr8ui4lxvTm L0sg== X-Gm-Message-State: AIkVDXIyiTrw6GRjoRK9mDImciVh1Vnt8Ga8qXJ9NCC9aqonyMut2ospZFnsi1ZPmPP/eA== X-Received: by 10.223.136.85 with SMTP id e21mr3907999wre.28.1484763240869; Wed, 18 Jan 2017 10:14:00 -0800 (PST) Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com. [74.125.82.41]) by smtp.gmail.com with ESMTPSA id y97sm6458758wmh.24.2017.01.18.10.14.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Jan 2017 10:14:00 -0800 (PST) Received: by mail-wm0-f41.google.com with SMTP id r144so38438579wme.1; Wed, 18 Jan 2017 10:14:00 -0800 (PST) X-Received: by 10.28.100.70 with SMTP id y67mr20659156wmb.45.1484763240630; Wed, 18 Jan 2017 10:14:00 -0800 (PST) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.194.29.72 with HTTP; Wed, 18 Jan 2017 10:14:00 -0800 (PST) In-Reply-To: <201701181755.v0IHtnNX059783@repo.freebsd.org> References: <201701181755.v0IHtnNX059783@repo.freebsd.org> From: Conrad Meyer Date: Wed, 18 Jan 2017 10:14:00 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r312391 - in head: share/man/man5 sys/ufs/ufs To: svn-src-head@freebsd.org Cc: src-committers , svn-src-all@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2017 18:14:08 -0000 On Wed, Jan 18, 2017 at 9:55 AM, Conrad E. Meyer wrote: > Author: cem > Date: Wed Jan 18 17:55:49 2017 > New Revision: 312391 > URL: https://svnweb.freebsd.org/changeset/base/312391 > > Log: > ufs/extattr.h: Fix documentation of ea_name termination > > The ea_name string is not nul-terminated. Correct the documentation. > > Because the subsequent field is padded to 8 bytes, and the padding is > zeroed, the ea_name string will appear to be nul-terminated whenever th= e > length isn't exactly one (mod eight). > > This was introduced in r167010 (2007). > > Additionally, mark the length fields as unsigned. This particularly > matters for the single byte ea_namelength field, which can represent > extended attribute names up to 255 bytes long. > > No functional change. Whoops =E2=80=94 very minor functional change =E2=80=94 restore(8) can now = handle some dumps with extended attribute names longer than 127 characters that it couldn't before, due to the unsigned type change called out above. Best, Conrad