From owner-cvs-all@FreeBSD.ORG Mon Sep 8 20:12:10 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ABC49106569E; Mon, 8 Sep 2008 20:12:10 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 4B7458FC15; Mon, 8 Sep 2008 20:12:10 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from zion.baldwin.cx (zion.baldwin.cx [IPv6:2001:470:1f11:75:2a0:d2ff:fe18:8b38]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m88KBvuE095950; Mon, 8 Sep 2008 16:12:03 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Sam Leffler Date: Mon, 8 Sep 2008 14:10:56 -0400 User-Agent: KMail/1.9.7 References: <200809010531.m815VOf0085178@repoman.freebsd.org> <48BC102C.3080508@freebsd.org> In-Reply-To: <48BC102C.3080508@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200809081410.57357.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:2001:470:1f11:75::1]); Mon, 08 Sep 2008 16:12:04 -0400 (EDT) X-Virus-Scanned: ClamAV 0.93.1/8162/Thu Sep 4 12:38:45 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Kip Macy , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/cxgb/ulp/toecore toedev.c src/sys/netinet tcp_offload.c toedev.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Sep 2008 20:12:10 -0000 On Monday 01 September 2008 11:54:20 am Sam Leffler wrote: > Kip Macy wrote: > > kmacy 2008-09-01 05:30:22 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/cxgb/ulp/toecore toedev.c > > sys/netinet tcp_offload.c toedev.h > > Log: > > SVN rev 182591 on 2008-09-01 05:30:22Z by kmacy > > > > Don't check if an interface can do tcp offload if there are no offload > > devices registered on the system. > > This appears to have an unrelated change as well: > > /* > > * Look up the route used for the connection to > > * determine if it uses an interface capable of > > * offloading the connection. > > */ > > - rt = rtalloc1(nam, 1 /*report*/, 0 /*ignflags*/); > > + rt = rtalloc1(nam, 0 /*report*/, 0 /*ignflags*/); > > if (rt) > > RT_UNLOCK(rt); > > else > > Was that intentional? Maybe that is the source of the ARP breakage on 7.x? -- John Baldwin