Date: Sat, 21 Sep 2013 17:26:57 -0500 From: Bryan Drewery <bryan@shatow.net> To: Big Lebowski <spankthespam@gmail.com> Cc: freebsd-ports <freebsd-ports@freebsd.org> Subject: Re: Fwd: Help in testing Basho Riak port Message-ID: <523E1D31.5060302@shatow.net> In-Reply-To: <CAHcXP%2Beqn4izzfH9SCL_Qvs4Zv9jARKsa=nTRHsX8r_RunxrFQ@mail.gmail.com> References: <CAHcXP%2Be15099FK7ch3NhktHXJKcSL%2BstANhSSZ-zwfOtB6%2BLfA@mail.gmail.com> <20130920203737.GE74496@admin.xzibition.com> <CAHcXP%2BdjP3gTxDSQ4DddingT8YbDaVLSp3HGL1sQahBxU1cG9w@mail.gmail.com> <CAHcXP%2Beqn4izzfH9SCL_Qvs4Zv9jARKsa=nTRHsX8r_RunxrFQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mx9ghbAUl20VBdkRAj5XWDvRp1WlVWC6A Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 9/21/2013 5:08 PM, Big Lebowski wrote: > Hi, >=20 > Thanks for your comments, see mine below. >=20 >=20 > On Fri, Sep 20, 2013 at 9:37 PM, Bryan Drewery <bryan@shatow.net> wrote= : >=20 >> On Fri, Sep 20, 2013 at 06:57:52PM +0100, Big Lebowski wrote: >>> Hi list! >>> >>> I've been working for couple last days on porting Basho Riak database= >>> (latest version 1.4.2) and finally I think it is ready to be presente= d: >>> https://www.dropbox.com/s/2ztu2bdiip1u2un/riak.tgz >> >> MASTER_SITES=3D >> http://s3.amazonaws.com/downloads.basho.com/riak/1.4/1.4.2/ \ >> >> http://downloads.basho.com.s3.amazonaws.com/riak/1.4/1.4.2/ >> >> Use ${PORTVERSION} instead of 1.4.2 >> >=20 > Fixed. >=20 >=20 >> >> USES=3D ${GMAKE} >> >> Use 'gmake', not ${GMAKE} here. >> >=20 > Fixed. >=20 >=20 >> >> Fails to build on 8.3 i386: >> >> db/version_set.cc:59: warning: this decimal constant is unsigned onl= y in >> ISO C90 >> db/version_set.cc:59: warning: this decimal constant is unsigned onl= y in >> ISO C90 >> db/version_set.cc:60: error: integer constant is too large for 'long= ' >> type >> db/version_set.cc:60: error: integer constant is too large for 'long= ' >> type >> db/version_set.cc:61: error: integer constant is too large for 'long= ' >> type >> db/version_set.cc:61: error: integer constant is too large for 'long= ' >> type >> db/version_set.cc:62: error: integer constant is too large for 'long= ' >> type >> db/version_set.cc:62: error: integer constant is too large for 'long= ' >> type >> table/filter_block.cc: In member function 'bool >> leveldb::FilterBlockReader::KeyMayMatch(uint64_t, const leveldb::Slice= &)': >> table/filter_block.cc:112: warning: comparison between signed and >> unsigned integer expressions >> util/env_posix.cc: In constructor >> 'leveldb::<unnamed>::PosixEnv::PosixEnv()': >> util/env_posix.cc:788: warning: unused variable 'ts' >> >> >> gmake[1]: *** [libleveldb.so.1.9] Error 1 >> gmake[1]: Leaving directory >> `/wrkdirs/usr/ports/databases/riak/work/riak-1.4.2/deps/eleveldb/c_src= /leveldb' >> >=20 > Can you provide any more details on your testing environment, like 32/6= 4 > bit, GCC version, any compile optimizations in make.conf and so on? > Unfortunately, I dont have any 8.x machine to test it, so I wasnt able = to > see that before. Could you also try to build it on 8.3 using CLANG? 8.3 i386 (32 bit). GCC 4.2. This error is of too much data for 32bit variable. Clang won't help. Here is the issue upstream as well with a recommended fix and a SO explaining more: https://github.com/basho/leveldb/issues/87 http://stackoverflow.com/questions/5541560/integer-constant-is-too-large-= for-long-type >=20 >=20 >> >> >> Instead of bsd.port.pre.mk ... bsd.port.post.mk, use bsd.port.options.= mk... >> bsd.port.mk. Although, it doesn't look like you even need that. Just u= se >> bsd.port.mk at the end, no 2nd include. >> >=20 > I dont think I can get away with only using bsd.port.mk - I've tried th= at, > and the port fails miserably, somwhere on the level of interpretation o= f > the Makefile, where it is missing many macros, so I've stayed with two > includes. >=20 >=20 >> >> >> Otherwise, good work. I will pkg-build test any updates you send out. >> >=20 > Thanks, great to hear that. Latest version will be posted in response t= o my > original message. >=20 > B. >=20 >=20 >> >>> >>> Please, grab the port and test it on anything you can, break it in an= y >> way >>> possible, and comment on anything you see that's been done wrong - I = am >>> open to any suggestion on how to make it worthy candidate for send-pr= >> with >>> port submission. >>> >>> Any help will be highly appreciated and will motivate me to port more= >> cool >>> software to FreeBSD! ;) >>> >>> Kind regards, >>> S. >>> _______________________________________________ >>> freebsd-ports@freebsd.org mailing list >>> http://lists.freebsd.org/mailman/listinfo/freebsd-ports >>> To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.o= rg" >> > _______________________________________________ > freebsd-ports@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-ports > To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org= " >=20 --mx9ghbAUl20VBdkRAj5XWDvRp1WlVWC6A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSPh0xAAoJEG54KsA8mwz5N/sP/2QjN9smEhw7ROJEFksKD37/ BKBLK+FaGIlBDtyfVMzvnBvwd48R3MYoqsiD1MOq/BnvN5sy9c/Hzwwx68MrnxGC YuXMr2Sob9+pgdHZJ3pDjPTUT7RmNtthEF4P5cmw7dzhM71wpbIlHqYOxk23oQ/G XRXVjfZtbj1pRa/2utIRvbNwhKnbFV5KjQO1/CIQBkKjkqI8bh/nwLgEVVyCgO/A fdRhjnBfmzjvKLXcDUygf/Y5lUW3sNZLGqnTDSByHwyfNCCswFCLShMeXO3tjibG 8xE5YCjnZIY8kot+EUOy0UfVtNJJHHzrhF30VCXtRxbKM56f+ZpMWm3POT1X4YHD uZt9Zvg1GD6Wz9rTzxtkkY9q91x0M5VuKfpBdPTKiwGk4pl2kC29QR6hMaUT9hLg Zh58Dc276XixlUiXI3pPgm4jBJdCxhaDdgKmN295bFLBq53sOJ9T+SkH+WfMH9qg TTWXjfTIZeRD7V6+OxZlmIZDRzdctkiSQuqNmuVcKy/zxDhpv/xDt2wXUQC8sW3G qjbmbManyzUMuUpD559FZTYss3YKEtJSSyyP0bkroOIYw1KyciXHH4+YTzZba18m s6o0LQ48KBp1qOx93YLou4iNOQNfZ+5+qP9Q2ZCB2fq7FJUvxLqkxcIkWj63R/ex 8XIvbiM63gRr8sziKHEe =8Q01 -----END PGP SIGNATURE----- --mx9ghbAUl20VBdkRAj5XWDvRp1WlVWC6A--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?523E1D31.5060302>