From owner-dev-commits-src-all@freebsd.org Tue Jul 13 10:13:25 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3F95565701D; Tue, 13 Jul 2021 10:13:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GPGg919ncz3t4k; Tue, 13 Jul 2021 10:13:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1043420A8F; Tue, 13 Jul 2021 10:13:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 16DADOr5097641; Tue, 13 Jul 2021 10:13:24 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 16DADOix097639; Tue, 13 Jul 2021 10:13:24 GMT (envelope-from git) Date: Tue, 13 Jul 2021 10:13:24 GMT Message-Id: <202107131013.16DADOix097639@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Edward Tomasz Napierala Subject: git: 3eaf271d3c0e - main - linux(4): Improve comment about SA_RESTORER MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: trasz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3eaf271d3c0e4fa18b74971a71c950fd43fa4189 Auto-Submitted: auto-generated X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jul 2021 10:13:25 -0000 The branch main has been updated by trasz: URL: https://cgit.FreeBSD.org/src/commit/?id=3eaf271d3c0e4fa18b74971a71c950fd43fa4189 commit 3eaf271d3c0e4fa18b74971a71c950fd43fa4189 Author: Edward Tomasz Napierala AuthorDate: 2021-07-13 09:38:08 +0000 Commit: Edward Tomasz Napierala CommitDate: 2021-07-13 10:13:17 +0000 linux(4): Improve comment about SA_RESTORER No functional changes. Sponsored By: EPSRC --- sys/compat/linux/linux_signal.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/sys/compat/linux/linux_signal.c b/sys/compat/linux/linux_signal.c index d0f1bb1c3b32..43213301239c 100644 --- a/sys/compat/linux/linux_signal.c +++ b/sys/compat/linux/linux_signal.c @@ -96,7 +96,12 @@ linux_to_bsd_sigaction(l_sigaction_t *lsa, struct sigaction *bsa) } if (lsa->lsa_flags & LINUX_SA_RESTORER) { flags &= ~LINUX_SA_RESTORER; - /* XXX: We might want to handle it; see Linux sigreturn(2). */ + /* + * We ignore the lsa_restorer and always use our own signal + * trampoline instead. It looks like SA_RESTORER is obsolete + * in Linux too - it doesn't seem to be used at all on arm64. + * In any case: see Linux sigreturn(2). + */ } if (lsa->lsa_flags & LINUX_SA_ONSTACK) { flags &= ~LINUX_SA_ONSTACK;