From owner-cvs-src@FreeBSD.ORG Thu Nov 29 17:18:11 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9088116A41A; Thu, 29 Nov 2007 17:18:11 +0000 (UTC) (envelope-from marcus@FreeBSD.org) Received: from av-tac-rtp.cisco.com (hen.cisco.com [64.102.19.198]) by mx1.freebsd.org (Postfix) with ESMTP id 16E0413C4E5; Thu, 29 Nov 2007 17:18:10 +0000 (UTC) (envelope-from marcus@FreeBSD.org) X-TACSUNS: Virus Scanned Received: from rooster.cisco.com (localhost [127.0.0.1]) by av-tac-rtp.cisco.com (8.11.7p3+Sun/8.11.7) with ESMTP id lATH6t422929; Thu, 29 Nov 2007 12:06:55 -0500 (EST) Received: from [64.102.220.116] (dhcp-64-102-220-116.cisco.com [64.102.220.116]) by rooster.cisco.com (8.11.7p3+Sun/8.11.7) with ESMTP id lATH7Hu17518; Thu, 29 Nov 2007 12:07:17 -0500 (EST) Message-ID: <474EF1D5.7070103@FreeBSD.org> Date: Thu, 29 Nov 2007 12:07:33 -0500 From: Joe Marcus Clarke Organization: FreeBSD, Inc. User-Agent: Thunderbird 2.0.0.9 (Macintosh/20071031) MIME-Version: 1.0 To: Peter Wemm References: <200711290634.lAT6YUpr004269@repoman.freebsd.org> In-Reply-To: <200711290634.lAT6YUpr004269@repoman.freebsd.org> X-Enigmail-Version: 0.95.5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/linprocfs linprocfs.c src/sys/kern kern_clock.c src/sys/sys pcpu.h resource.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2007 17:18:11 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Peter Wemm wrote: > peter 2007-11-29 06:34:30 UTC > > FreeBSD src repository > > Modified files: > sys/compat/linprocfs linprocfs.c > sys/kern kern_clock.c > sys/sys pcpu.h resource.h > Log: > Move the shared cp_time array (counts %sys, %user, %idle etc) to the > per-cpu area. cp_time[] goes away and a new function creates a merged > cp_time-like array for things like linprocfs, sysctl etc. The > atomic ops for updating cp_time[] in statclock go away, and the scope > of the thread lock is reduced. > > sysctl kern.cp_time returns a backwards compatible cp_time[] array. > A new kern.cp_times sysctl returns the individual per-cpu stats. > > I have pending changes to make top and vmstat optionally show per-cpu > stats. > > I'm very aware that there are something like 5 or 6 other versions "out > there" for doing this - but none were handy when I needed them. > > I did merge my changes with John Baldwin's, and ended up replacing a > few chunks of my stuff with his, and stealing some other code. libgtop uses the cp_time interface. Can __FreeBSD_version be bumped for this? And thanks for doing this work. Joe - -- Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHTvHVb2iPiv4Uz4cRApN5AJ9OXOOicAnbEs41XoxZiYci0VTnhQCdE6j7 02j4z12cfDT3xDTfuorGBTk= =3ipu -----END PGP SIGNATURE-----