From owner-p4-projects@FreeBSD.ORG  Wed Oct 11 23:19:38 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id C9E3616A492; Wed, 11 Oct 2006 23:19:38 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 63FD816A407
	for <perforce@freebsd.org>; Wed, 11 Oct 2006 23:19:38 +0000 (UTC)
	(envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85])
	by mx1.FreeBSD.org (Postfix) with ESMTP id EEE9943D58
	for <perforce@freebsd.org>; Wed, 11 Oct 2006 23:19:37 +0000 (GMT)
	(envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k9BNGZL5046099;
	Wed, 11 Oct 2006 17:16:36 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Wed, 11 Oct 2006 17:15:47 -0600 (MDT)
Message-Id: <20061011.171547.1291029425.imp@bsdimp.com>
To: hselasky@c2i.net
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <200610120027.10842.hselasky@c2i.net>
References: <200610080546.k985k2Eb052621@repoman.freebsd.org>
	<200610120027.10842.hselasky@c2i.net>
X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0
	(harmony.bsdimp.com [127.0.0.1]);
	Wed, 11 Oct 2006 17:16:37 -0600 (MDT)
Cc: perforce@freebsd.org
Subject: Re: PERFORCE change 107486 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Oct 2006 23:19:39 -0000

In message: <200610120027.10842.hselasky@c2i.net>
            Hans Petter Selasky <hselasky@c2i.net> writes:
: On Sunday 08 October 2006 07:46, Warner Losh wrote:
: > http://perforce.freebsd.org/chv.cgi?CH=107486
: >
: > Change 107486 by imp@imp_paco-paco on 2006/10/08 05:45:21
: >
: >  compile
: >
: > Affected files ...
: >
: > .. //depot/projects/usb/src/sys/dev/usb/udbp.h#5 edit
: >
: > Differences ...
: >
: > ==== //depot/projects/usb/src/sys/dev/usb/udbp.h#5 (text+ko) ====
: >
: > @@ -60,8 +60,8 @@
: >
: >  /* This structure is returned by the NGM_UDBP_GET_STATUS command */
: >  struct ngudbpstat {
: > - uint packets_in; /* packets in from downstream */
: > - uint packets_out; /* packets out towards downstream */
: > + int packets_in; /* packets in from downstream */
: > + int packets_out; /* packets out towards downstream */
: >  };
: 
: Are you sure that this shouldn't be "uint32_t" ?

I'm not sure what it should be.  I just made it int to compile.  Feel
free to change it to a better type.

Warner