From owner-cvs-all  Tue Sep 10  7:32:21 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 71BA637B400; Tue, 10 Sep 2002 07:32:14 -0700 (PDT)
Received: from chiark.greenend.org.uk (chiark.greenend.org.uk [212.135.138.206])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id B6ED643E3B; Tue, 10 Sep 2002 07:32:12 -0700 (PDT)
	(envelope-from fanf@chiark.greenend.org.uk)
Received: from fanf by chiark.greenend.org.uk with local (Exim 3.12 #1)
	id 17om3n-0006Fg-00 (Debian); Tue, 10 Sep 2002 15:32:11 +0100
Date: Tue, 10 Sep 2002 15:32:11 +0100
From: Tony Finch <dot@dotat.at>
To: Juli Mallett <jmallett@FreeBSD.org>
Cc: Tony Finch <fanf@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/share/man/man9 style.9
Message-ID: <20020910153211.E14317@chiark.greenend.org.uk>
References: <200209101054.g8AAseoS004374@freefall.freebsd.org> <20020910071126.B44916@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <20020910071126.B44916@FreeBSD.org>; from jmallett@FreeBSD.org on Tue, Sep 10, 2002 at 07:11:26AM -0700
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Tue, Sep 10, 2002 at 07:11:26AM -0700, Juli Mallett wrote:
> 
> Any chance of us adopting the Mach (and Lites) policy of doing
> <sys/macro_help.h> (actually <mach/macro_help.h>), and having some
> macros like
> 
> #define	MACRO_BEGIN	do {
> #define	MACRO_END	} while(0)	/* or with a ; if you like that */
> 
> ?

I think this goes against the general policy in style(9) of assuming
that the readers and writers of the code know C and its idioms. It
also reduces portability. It misses out the other kinds of bracketing
that macros need to do, depending on whether they are expressions or
declarations as well as statements.

Tony.
-- 
f.a.n.finch <dot@dotat.at> http://dotat.at/
FISHER: EAST 5 OR 6, BECOMING VARIABLE, MAINLY EAST, 3 OR 4 IN SOUTH. THUNDERY
SHOWERS. MODERATE OR GOOD.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message