From owner-freebsd-hackers Fri Jul 9 1:29:22 1999 Delivered-To: freebsd-hackers@freebsd.org Received: from not.demophon.com (ns.demophon.com [193.65.70.13]) by hub.freebsd.org (Postfix) with ESMTP id 4F5FA14DD6 for ; Fri, 9 Jul 1999 01:29:19 -0700 (PDT) (envelope-from will@not.demophon.com) Received: (from will@localhost) by not.demophon.com (8.9.3/8.8.7) id LAA01377; Fri, 9 Jul 1999 11:24:09 +0300 (EEST) (envelope-from will) To: zzhang@cs.binghamton.edu (Zhihui Zhang) Cc: hackers@freebsd.org Subject: Re: Wrong comment in VM code? References: From: Ville-Pertti Keinonen Date: 09 Jul 1999 11:24:09 +0300 In-Reply-To: zzhang@cs.binghamton.edu's message of "9 Jul 1999 04:37:52 +0300" Message-ID: <86iu7ujknq.fsf@not.demophon.com> Lines: 19 X-Mailer: Gnus v5.5/XEmacs 20.4 - "Emerald" Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG zzhang@cs.binghamton.edu (Zhihui Zhang) writes: > At the beginning of the file vm_object.c, we have the following comment: > > The only items within the object structure which are modified after time > of creation are: > > reference count locked by object's lock > pager routine locked by object's lock > > But at the end of vnode_pager_setsize(), we modify the size field. So at > least three items can be modified after creation. Am I right? The comment is wrong (it's probably supposed to mean something other than it seems to), the only field in a vm_object that *isn't* modified after creation is 'id'. The comment is also wrong in that there are no vm_object locks in FreeBSD (they've been ripped out). To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message