Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 21 Feb 2011 01:19:09 +0000 (UTC)
From:      Pyun YongHyeon <yongari@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org
Subject:   svn commit: r218905 - in stable/8/sys: dev/re pci
Message-ID:  <201102210119.p1L1J9Z0051249@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: yongari
Date: Mon Feb 21 01:19:09 2011
New Revision: 218905
URL: http://svn.freebsd.org/changeset/base/218905

Log:
  MFC r217524,217766:
    Change model names of controller RTL_HWREV_8168_SPIN[123] to real ones.
    s/RL_HWREV_8168_SPIN1/RL_HWREV_8168B_SPIN1/g
    s/RL_HWREV_8168_SPIN2/RL_HWREV_8168B_SPIN2/g
    s/RL_HWREV_8168_SPIN3/RL_HWREV_8168B_SPIN3/g
    No functional changes.
  
  r217766:
    Apply TX interrupt moderation to all RTL810xE PCIe Fast Ethernet
    controllers. Experimentation with RTL8102E, RTL8103E and RTL8105E
    showed dramatic decrement of TX completion interrupts under high TX
    load(e.g.  from 147k interrupts/second to 10k interrupts/second)
    With this change, TX interrupt moderation is applied to all
    controllers except RTL8139C+.

Modified:
  stable/8/sys/dev/re/if_re.c
  stable/8/sys/pci/if_rlreg.h
Directory Properties:
  stable/8/sys/   (props changed)
  stable/8/sys/amd64/include/xen/   (props changed)
  stable/8/sys/cddl/contrib/opensolaris/   (props changed)
  stable/8/sys/contrib/dev/acpica/   (props changed)
  stable/8/sys/contrib/pf/   (props changed)

Modified: stable/8/sys/dev/re/if_re.c
==============================================================================
--- stable/8/sys/dev/re/if_re.c	Mon Feb 21 01:15:11 2011	(r218904)
+++ stable/8/sys/dev/re/if_re.c	Mon Feb 21 01:19:09 2011	(r218905)
@@ -197,7 +197,7 @@ static struct rl_hwrev re_hwrevs[] = {
 	{ RL_HWREV_8139C, RL_8139, "C", RL_MTU },
 	{ RL_HWREV_8139D, RL_8139, "8139D/8100B/8100C", RL_MTU },
 	{ RL_HWREV_8139CPLUS, RL_8139CPLUS, "C+", RL_MTU },
-	{ RL_HWREV_8168_SPIN1, RL_8169, "8168", RL_JUMBO_MTU },
+	{ RL_HWREV_8168B_SPIN1, RL_8169, "8168", RL_JUMBO_MTU },
 	{ RL_HWREV_8169, RL_8169, "8169", RL_JUMBO_MTU },
 	{ RL_HWREV_8169S, RL_8169, "8169S", RL_JUMBO_MTU },
 	{ RL_HWREV_8110S, RL_8169, "8110S", RL_JUMBO_MTU },
@@ -213,8 +213,8 @@ static struct rl_hwrev re_hwrevs[] = {
 	{ RL_HWREV_8102EL, RL_8169, "8102EL", RL_MTU },
 	{ RL_HWREV_8102EL_SPIN1, RL_8169, "8102EL", RL_MTU },
 	{ RL_HWREV_8103E, RL_8169, "8103E", RL_MTU },
-	{ RL_HWREV_8168_SPIN2, RL_8169, "8168", RL_JUMBO_MTU },
-	{ RL_HWREV_8168_SPIN3, RL_8169, "8168", RL_JUMBO_MTU },
+	{ RL_HWREV_8168B_SPIN2, RL_8169, "8168", RL_JUMBO_MTU },
+	{ RL_HWREV_8168B_SPIN3, RL_8169, "8168", RL_JUMBO_MTU },
 	{ RL_HWREV_8168C, RL_8169, "8168C/8111C", RL_JUMBO_MTU_6K },
 	{ RL_HWREV_8168C_SPIN2, RL_8169, "8168C/8111C", RL_JUMBO_MTU_6K },
 	{ RL_HWREV_8168CP, RL_8169, "8168CP/8111CP", RL_JUMBO_MTU_6K },
@@ -1334,11 +1334,11 @@ re_attach(device_t dev)
 		    RL_FLAG_MACSTAT | RL_FLAG_FASTETHER | RL_FLAG_CMDSTOP |
 		    RL_FLAG_AUTOPAD | RL_FLAG_MACSLEEP;
 		break;
-	case RL_HWREV_8168_SPIN1:
-	case RL_HWREV_8168_SPIN2:
+	case RL_HWREV_8168B_SPIN1:
+	case RL_HWREV_8168B_SPIN2:
 		sc->rl_flags |= RL_FLAG_WOLRXENB;
 		/* FALLTHROUGH */
-	case RL_HWREV_8168_SPIN3:
+	case RL_HWREV_8168B_SPIN3:
 		sc->rl_flags |= RL_FLAG_PHYWAKE | RL_FLAG_MACSTAT;
 		break;
 	case RL_HWREV_8168C_SPIN2:
@@ -2941,20 +2941,8 @@ re_init_locked(struct rl_softc *sc)
 
 	/* Configure interrupt moderation. */
 	if (sc->rl_type == RL_8169) {
-		switch (sc->rl_hwrev->rl_rev) {
-		case RL_HWREV_8100E:
-		case RL_HWREV_8101E:
-		case RL_HWREV_8102E:
-		case RL_HWREV_8102EL:
-		case RL_HWREV_8102EL_SPIN1:
-		case RL_HWREV_8103E:
-			CSR_WRITE_2(sc, RL_INTRMOD, 0);
-			break;
-		default:
-			/* Magic from vendor. */
-			CSR_WRITE_2(sc, RL_INTRMOD, 0x5100);
-			break;
-		}
+		/* Magic from vendor. */
+		CSR_WRITE_2(sc, RL_INTRMOD, 0x5100);
 	}
 
 #ifdef DEVICE_POLLING

Modified: stable/8/sys/pci/if_rlreg.h
==============================================================================
--- stable/8/sys/pci/if_rlreg.h	Mon Feb 21 01:15:11 2011	(r218904)
+++ stable/8/sys/pci/if_rlreg.h	Mon Feb 21 01:19:09 2011	(r218905)
@@ -166,13 +166,13 @@
 #define	RL_HWREV_8168DP		0x28800000
 #define	RL_HWREV_8168E		0x2C000000
 #define	RL_HWREV_8168E_VL	0x2C800000
-#define	RL_HWREV_8168_SPIN1	0x30000000
+#define	RL_HWREV_8168B_SPIN1	0x30000000
 #define	RL_HWREV_8100E		0x30800000
 #define	RL_HWREV_8101E		0x34000000
 #define	RL_HWREV_8102E		0x34800000
 #define	RL_HWREV_8103E		0x34C00000
-#define	RL_HWREV_8168_SPIN2	0x38000000
-#define	RL_HWREV_8168_SPIN3	0x38400000
+#define	RL_HWREV_8168B_SPIN2	0x38000000
+#define	RL_HWREV_8168B_SPIN3	0x38400000
 #define	RL_HWREV_8168C		0x3C000000
 #define	RL_HWREV_8168C_SPIN2	0x3C400000
 #define	RL_HWREV_8168CP		0x3C800000



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201102210119.p1L1J9Z0051249>