Date: Mon, 16 Dec 2024 16:44:37 +0100 From: Olivier Certner <olce@freebsd.org> To: Cy Schubert <Cy.Schubert@cschubert.com>, Baptiste Daroussin <bapt@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: d2be7ed63aff - main - cred: proc_set_cred(), proc_unset_cred(): Update user's process count Message-ID: <2968186.slGk94SIus@ravel> In-Reply-To: <20241216152936.AC31A1AF@slippy.cwsent.com> References: <202412161445.4BGEjYvf052320@gitrepo.freebsd.org> <8184418.bYQgcRI8ro@ravel> <20241216152936.AC31A1AF@slippy.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart3019747.hHqAuc6tWs
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="UTF-8"; protected-headers="v1"
From: Olivier Certner <olce@freebsd.org>
Date: Mon, 16 Dec 2024 16:44:37 +0100
Message-ID: <2968186.slGk94SIus@ravel>
In-Reply-To: <20241216152936.AC31A1AF@slippy.cwsent.com>
MIME-Version: 1.0
> I was just about to push this:
Ah, didn't see your mail. Just pushed a fix.
> proc_set_cred(struct proc *p, struct ucred *newcred)
> {
> - bool success = _proc_set_cred(p, newcred, false);
> +#ifdef INVARIANTS
> + bool success =
> +#endif
> + _proc_set_cred(p, newcred, false);
>
> MPASS(success);
Apparently, the idiom for such a situation is to tag the variable with `__diagused`, but the change above would have worked the same in the end.
Thanks for watching the build!
(And I now have one more thing on my before-commit list, since I forgot GENERIC-NODEBUG).
--
Olivier Certner
--nextPart3019747.hHqAuc6tWs
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit
-----BEGIN PGP SIGNATURE-----
iQIzBAABCQAdFiEEmNCxHjkosai0LYIujKEwQJceJicFAmdgSuUACgkQjKEwQJce
Jif96g/+LTFhLnCChMdqh+uIxuQIER1oWL0fSdSLpHx0wMAMvL0zkz2OyBLXB3ta
caatuSsUpyzTe5jPCoWtWcgFzfSZZqdu9z+sYnbI5bxVi9GD3A76z6CjeYGuj4f/
+Dr7XT7xrIhye8GZLjGCLc0rZ+qpYAyOvtyL5kFzJrFfV0Lu35VyN/Bho05X7QMv
Yn5zZlKD8PSFXZV302uMQhb4OmlFJG8aGHDyiyf8x5SEJhZtvoTdmAHngNiCYF97
31zRK8CuU7Yu30eG0RCxiBrjK6U9OOlRQGP/sBKna89tctsYJ17nYlNnKlz5PF0r
q8QgaKd20ruPHmE10ZGn4ElX+sIAqs7IzyOotd19PVbg+JMMmL4ywTabAGNZqCgZ
uETCunLMGje8BzjOVoO1rL25EscPwinQ+fxQvq5vbAUBqNbXeGziSCNbf09vStS/
M3NJoIWua37JsKbLP1sz9z8tAVwN4m9W0oKZIxJrThFYObqmHBM8gaboZzk+P8yo
LSQ6YsxRO3bDh6m2492CC9QN//Szm5FVtH629wCzwUVtx8m9PFK38+i1NcHfPkB5
FIKRXKnnGVS8ubaJMG+7pasz255474aX+h0DtkyjK4B9GIPmuBS1JUp+UVrR+XIF
24QD9jk22TD2FdTKpXRMZdWp88Vn8xgxujhqq2qWtXZWOScH8xE=
=Nk00
-----END PGP SIGNATURE-----
--nextPart3019747.hHqAuc6tWs--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2968186.slGk94SIus>