From owner-cvs-all@FreeBSD.ORG  Tue Jan 17 11:52:04 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E301C16A41F;
	Tue, 17 Jan 2006 11:52:04 +0000 (GMT)
	(envelope-from dfr@nlsystems.com)
Received: from mail.qubesoft.com (gate.qubesoft.com [217.169.36.34])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5443C43D45;
	Tue, 17 Jan 2006 11:52:03 +0000 (GMT)
	(envelope-from dfr@nlsystems.com)
Received: from [10.201.19.245] (doug02.dyn.qubesoft.com [10.201.19.245])
	by mail.qubesoft.com (8.13.3/8.13.3) with ESMTP id k0HBq2ND018074;
	Tue, 17 Jan 2006 11:52:02 GMT (envelope-from dfr@nlsystems.com)
In-Reply-To: <200512202106.jBKL6hNr035186@repoman.freebsd.org>
References: <200512202106.jBKL6hNr035186@repoman.freebsd.org>
Mime-Version: 1.0 (Apple Message framework v746.2)
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-Id: <1CDDC33C-01D5-4AFE-99C0-DE848321D78B@nlsystems.com>
Content-Transfer-Encoding: 7bit
From: Doug Rabson <dfr@nlsystems.com>
Date: Tue, 17 Jan 2006 11:51:59 +0000
To: John Baldwin <jhb@FreeBSD.org>
X-Mailer: Apple Mail (2.746.2)
X-Spam-Status: No, score=-2.8 required=5.0 tests=ALL_TRUSTED autolearn=failed 
	version=3.0.4
X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.qubesoft.com
X-Virus-Scanned: ClamAV 0.86.2/1244/Tue Jan 17 08:46:07 2006 on
	mail.qubesoft.com
X-Virus-Status: Clean
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/pci agp.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Jan 2006 11:52:05 -0000


On 20 Dec 2005, at 21:06, John Baldwin wrote:

> jhb         2005-12-20 21:06:43 UTC
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/pci              agp.c
>   Log:
>   Change the agp_find_device() to return the first agp device that  
> has been
>   attached to a driver rather than always returning agp0.

According to Coverity, this introduces a memory leak  
(devclass_get_devices() allocates memory).