From owner-freebsd-current Sat Aug 10 6:59:53 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B9F8237B400 for ; Sat, 10 Aug 2002 06:59:50 -0700 (PDT) Received: from slimy.rodal.no (ti121210a080-0683.bb.online.no [80.212.2.171]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0471743E5E for ; Sat, 10 Aug 2002 06:59:49 -0700 (PDT) (envelope-from morten@rodal.no) Received: from slurp.rodal.no (morten@slurp.rodal.no [IPv6:2001:470:1f00:211:210:4bff:fe3e:2358]) by slimy.rodal.no (8.12.3/8.12.3) with ESMTP id g7ADxg6A006777; Sat, 10 Aug 2002 15:59:42 +0200 (CEST) (envelope-from morten@slurp.rodal.no) Received: (from morten@localhost) by slurp.rodal.no (8.12.5/8.12.5/Submit) id g7ADxgoR060855; Sat, 10 Aug 2002 15:59:42 +0200 (CEST) (envelope-from morten) Date: Sat, 10 Aug 2002 15:59:42 +0200 From: Morten Rodal To: Eirik Nygaard Cc: current@FreeBSD.ORG Subject: Re: Rewrite of the perl script rmuser to C Message-ID: <20020810135941.GF6050@slurp.rodal.no> References: <20020810120239.GB1064@test.eirikn.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="MIdTMoZhcV1D07fI" Content-Disposition: inline In-Reply-To: <20020810120239.GB1064@test.eirikn.net> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --MIdTMoZhcV1D07fI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 10, 2002 at 02:02:39PM +0200, Eirik Nygaard wrote: > I have just rewritten the rmuser perl script to C, it would be=20 > great if you could take a look at it and check if everything is ok. You should probably replace the strcpy() and strcat() with strlcpy(3) and strlcat(3), or at least use the strncpy(3) and strncat(3). Also, sprintf() should be replaced with snprintf(3). Maybe close the file descriptors in the signal handlers? >=20 > How do I get this commited? Now that I cannot answer for :) -- Morten Rodal // // PGP ID 2D75595B // 22DE D67A 1AEA EF94 872A 9384 6D67 B50B 2D75 595B // --MIdTMoZhcV1D07fI Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) iD8DBQE9VRxNbWe1Cy11WVsRAt1CAJ40d/aSFEJSlQ/GW/jXWcCvnC/D7ACgwjVo Yv7VDTbYnpY89+0iV5i2Wr8= =mIlW -----END PGP SIGNATURE----- --MIdTMoZhcV1D07fI-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message