From owner-freebsd-hackers@FreeBSD.ORG Tue Jul 11 08:27:15 2006 Return-Path: X-Original-To: freebsd-hackers@freebsd.org Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5074B16A4ED for ; Tue, 11 Jul 2006 08:27:15 +0000 (UTC) (envelope-from des@des.no) Received: from tim.des.no (tim.des.no [194.63.250.121]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2E7FB43DB1 for ; Tue, 11 Jul 2006 08:26:38 +0000 (GMT) (envelope-from des@des.no) Received: from tim.des.no (localhost [127.0.0.1]) by spam.des.no (Postfix) with ESMTP id 0F3ED2088; Tue, 11 Jul 2006 10:26:32 +0200 (CEST) X-Spam-Tests: AWL X-Spam-Learn: disabled X-Spam-Score: 0.0/3.0 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on tim.des.no Received: from xps.des.no (des.no [80.203.243.180]) by tim.des.no (Postfix) with ESMTP id F31402087; Tue, 11 Jul 2006 10:26:31 +0200 (CEST) Received: by xps.des.no (Postfix, from userid 1001) id B536033C1F; Tue, 11 Jul 2006 10:26:31 +0200 (CEST) From: des@des.no (Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?=) To: mag@intron.ac References: <200607092136.k69LaNDX055391@www.freebsd.org> <84dead720607092015q7f1701abse143f3855c2aa95a@mail.gmail.com> <1152540567.99616@origin.intron.ac> <44B2AE69.4080703@elischer.org> <44B2D2DF.2000401@sh.cvut.cz> <86sll8zl9x.fsf@xps.des.no> Date: Tue, 11 Jul 2006 10:26:31 +0200 In-Reply-To: (mag@intron.ac's message of "Tue, 11 Jul 2006 16:13:48 +0800") Message-ID: <86fyh8zgw8.fsf@xps.des.no> User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-hackers@freebsd.org, delphij@delphij.net, Julian Elischer Subject: Re: kern/99979: Get Ready for Kernel Module in C++ X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jul 2006 08:27:15 -0000 mag@intron.ac writes: > But prior to long-term discussion, please commit my 4 patches > firstly. They are nearly CPP-independent and do no harm to current > FreeBSD kernel. We don't do the kind of changes you propose without discussion. > --- kern.mk.orig Fri Jun 30 05:15:25 2006 > +++ kern.mk Mon Jul 10 18:42:43 2006 > @@ -88,7 +88,7 @@ > .if ${CC} =3D=3D "icc" > CFLAGS+=3D -nolib_inline > .else > -CFLAGS+=3D -ffreestanding > +CFLAGS+=3D -fno-builtin > .endif Are you sure this is correct? I'm pretty certain it isn't. The kernel's C environment is not a hosted implementation. > --- systm.h.orig Mon Jul 10 05:42:58 2006 > +++ systm.h Mon Jul 10 18:44:01 2006 > @@ -203,7 +203,7 @@ > int suword16(void *base, int word); > int suword32(void *base, int32_t word); > int suword64(void *base, int64_t word); > -intptr_t casuptr(intptr_t *p, intptr_t old, intptr_t new); > +intptr_t casuptr(intptr_t *p, intptr_t old, intptr_t __new__); This is a namespace violation. A simpler solution is to leave out argument names entirely. DES --=20 Dag-Erling Sm=F8rgrav - des@des.no