From owner-freebsd-current@FreeBSD.ORG Wed Jul 22 18:17:51 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2BD60106566C for ; Wed, 22 Jul 2009 18:17:51 +0000 (UTC) (envelope-from sektie@gmail.com) Received: from mail-qy0-f191.google.com (mail-qy0-f191.google.com [209.85.221.191]) by mx1.freebsd.org (Postfix) with ESMTP id D37F28FC0A for ; Wed, 22 Jul 2009 18:17:50 +0000 (UTC) (envelope-from sektie@gmail.com) Received: by qyk29 with SMTP id 29so484430qyk.3 for ; Wed, 22 Jul 2009 11:17:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type; bh=8S3Y+0mHMFLdwlOuyMNWrZgDt1+fUggFr0/rwFuLybw=; b=aFVKoC0Ki1DloZTaqu1fEvKepJoIk8reByiLsVhSlnC8TpB3D+Y40KGhIcfHvNrTNl kr6NkvPbWgvBaHaQAMMUGGShY/AWIkBKDLbaOtK/TU7tHL0xsmOAm7HnEh93O/ZgUYRV PMW83u3WAqTR29K0MKOEIsNwlh/Tv4WUMP1J0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=d8UsGsZPMlRdl8awZtpgqItzMptbgkVt7xsKVeso1RyOiHcyIur+d6HDtN5BYoeaAb GydFR2NvLrDSNDnxun0sTcgvciJ00/iN/LNp++PZbukWRn6RPLLIa48M73mJ6i1nnBcV oobWHj/sFTn+Glc5NQyFFVO7BH2qpqLz+4kVI= MIME-Version: 1.0 Sender: sektie@gmail.com Received: by 10.229.82.15 with SMTP id z15mr246252qck.32.1248285326156; Wed, 22 Jul 2009 10:55:26 -0700 (PDT) In-Reply-To: <200907221027.57244.doconnor@gsoft.com.au> References: <200907221027.57244.doconnor@gsoft.com.au> Date: Wed, 22 Jul 2009 10:55:25 -0700 X-Google-Sender-Auth: 404f8407f6813ee2 Message-ID: From: Randi Harper To: "Daniel O'Connor" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: David Boyd , freebsd-current@freebsd.org Subject: Re: 8.0-BETA2 sysinstall ignoring setting of nonInteractive X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jul 2009 18:17:51 -0000 On Tue, Jul 21, 2009 at 5:27 PM, Daniel O'Connor wrote: > On Wed, 22 Jul 2009, David Boyd wrote: > > With 8.0-BETA(1/2) sysinstall ignores setting of nonInteractive > > variable when using USB-based install. > > > > With or without nonInteractive sysinstall issues message "Using USB > > device: da0a" and waits for confirmation. > > > > This breaks unattended installations using USB device. > > I think this would fix it, can you test it? > > Index: media.c > =================================================================== > --- media.c (revision 195813) > +++ media.c (working copy) > @@ -262,7 +262,8 @@ > mediaDevice = devs[0]; > if (mediaDevice) > mediaDevice->private = NULL; > - msgConfirm("Using USB device: %s", mediaDevice->name); > + if (!variable_get(VAR_NONINTERACTIVE)) > + msgConfirm("Using USB device: %s", mediaDevice->name); > return (mediaDevice ? DITEM_LEAVE_MENU : DITEM_FAILURE); > } > Woops. :) I'll test this out later tonight and see if I can get the fix in. Thanks, Daniel. -- randi